#43121: abinit 7.4.3: update to revision 1 -------------------------+--------------------------------- Reporter: cram5431@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: haspatch maintainer Port: abinit | -------------------------+--------------------------------- Comment (by ryandesign@…): Thanks. A couple observations: * I see you added a "no_mpi" variant. For several years, we've been phasing out variants whose names begin with "no_", and we don't want to add any such new negatively-named variants; they should no longer be necessary. If a user doesn't want a functionality, they simply don't select the corresponding positively-named variant, or if that variant is on by default, they deselect it. MacPorts did not used to remember deselected variants during upgrades, but that bug was fixed years ago, removing the need for negatively-named variants. * I see you changed the presentation of ui_errors by putting a newline before and after your error text. This serves to make the display of errors in this port different from the display of errors in every other port, and that does not seem desirable. -- Ticket URL: <https://trac.macports.org/ticket/43121#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X