#19142: faac doesn't support mp4 ---------------------------------+------------------------------------------ Reporter: anddam@… | Owner: pguyot@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.7.0 Keywords: faac mp4 support | Port: faac ---------------------------------+------------------------------------------ Changes (by devans@…): * cc: pguyot@…, tristan@…, milosh@…, bytestorm@… (added) Comment: It's a bit confusing but the configuration option {{{ --with-mp4v2 compile libmp4v2 }}} means to build the embedded libmp4v2 source and without means to look for an external library which it does by looking in mp4.h etc. This is correct for the current MacPorts version of libmp4v2 and faac configures as follows {{ checking whether MP4Create is declared... yes checking for MP4MetadataDelete in -lmp4v2... yes checking whether MP4MetadataDelete is declared... yes checking for MP4MetadataDelete in -lmp4v2... (cached) yes configure: *** Building with external mp4v2 *** }}} The submitted patch addresses changes necessary to build against an upgraded version of libmp4v2 (not yet committed) as proposed in #19141 which is not compatible with the current version. I believe the mp4v2 variant proposed here is unnecessary (mp4 support should be the default) and incorrectly handles configuration using the external library. Patches would continue to be necessary to use the proposed upgraded library because of the change from mp4.h to mp4v2.h. However, a better patch for configure would be to look for either mp4.h or mp4v2.h and configure appropriately. I would be interested in whether/how the upstream developers intend to support this new version of libmp4v2. As packagers we should probably follow their lead. -- Ticket URL: <http://trac.macports.org/ticket/19142#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS