#48302: tomcat8 @ 8.0.24 looking for review/feedback/help -------------------------+-------------------------------- Reporter: raupach@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by cal@…): - `openmaintainer` is meaningless without a real maintainer associated with it. So either add yourself in the `domain.tld:localpart` obfuscated format, or just use `nomaintainer`. - We prefer `sha256` and `rmd160` checksums nowadays. If you delete the checksums line and run `port -v checksum`, the correct line will be printed. - You're mixing tabs and spaces in the `depends_lib` line - MacPorts has a `delete` command that wraps `file delete` that you could use instead of `file delete` in the pre-destroot block. I think it doesn't make a difference in this case, but it's still shorter. - If you're overriding the destroot phase anyway, there's little point in splitting out parts of it into pre- or post-destroot. - don't set `destroot.keepdirs` in a phase; do it at the top level of the Portfile - If you want, you can create a custom account for tomcat using the `add_users` directive. You could also use OS X' builtin `_www` user. - Please provide a launchd control interface so `port load tomcat8` will start and `port unload tomcat8` will stop the server. Search other Portfiles for `startupitem` to see how it's done -- if you need help, please feel free to ask here or on -dev. - If your port installs configuration files that should stay around after a user uninstalls the port and should not be overwritten by updates, move the configuration file by appending ".sample" and add a note (`notes your- text-here`) to tell the user that he needs to configure tomcat by creating the file before starting it. -- Ticket URL: <https://trac.macports.org/ticket/48302#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X