#47896: submission: cpuid --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: cpuid | --------------------------+-------------------------------- Comment (by rjvbertin@…): Replying to [comment:1 ionic@…]: Just a thing: this is (to be) an openmaintainer port, so anyone can feel free to make changes they see fit. I don't have commit permissions anyway.
Missing Id line.
This is a new Portfile written from scratch, not a fork of anything existing. If that line isn't generated automatically, what should I put on it?!
This is not a license.
There's only this to work with: {{{ * Copyright (c) 2010-2015, Steven Noonan <steven@uplinklabs.net> * * Permission to use, copy, modify, and/or distribute this software for any * purpose with or without fee is hereby granted, provided that the above * copyright notice and this permission notice appear in all copies. * * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. }}} I have no idea if that's an existing license and how it's called if so. I could call it the cpuid license or I can remove the license line completely.
`long_description` messed up.
In what sense? Prints well enough here...
`PortGroup` should come (directly) after `PortSystem`. I'm surprised this even works.
Fortunately that's not true: there are many ports that include portgroups in variants or subports. That wouldn't be possible if PortGroup should come *directly* after PortSystem. I like to organise Portfiles by section, with everything related to fetching grouped together after name, version and metadata.
Misses a dependency on `libgnugetopt`. Should not use the internal version => `NO_GNU_GETOPT`.
It doesn't. It uses an internal version if NO_GNU_GETOPT is set, but I don't see any evidence that that's the case. Build as is, the binary doesn't depend on a getopt (or any other) library (and I'd prefer it that way).
What the hell is CHUD? We probably don't want this either.
CHUD is sadly RIP; it was used in Shark, and here to emulate pthread_setaffinity_np(). It's not being linked anyway because the test whether to link CHUD fails. -- Ticket URL: <https://trac.macports.org/ticket/47896#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X