[MacPorts] #48516: qt5-mac, qt4-mac build error in qcocoacursor.mm
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ----------------------+-------------------------------- Reporter: eirnym@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: qt5-mac ----------------------+-------------------------------- QT5 has internal bug with qcocoacursor.mm. This fixed build with OS X 10.11 and incorrect usage for this function on previous Mac OS X releases. This is documented in upstream: https://bugreports.qt.io/browse/QTBUG-47641 This applicable for QT4, QT5 (5.4.2 and 5.5.0), OSX 10.4+ -- Ticket URL: <https://trac.macports.org/ticket/48516> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm -----------------------+------------------------ Reporter: eirnym@… | Owner: mcalhoun@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: qt5-mac | -----------------------+------------------------ Changes (by mf2k@…): * cc: mcalhoun@… (removed) * owner: macports-tickets@… => mcalhoun@… -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ------------------------------+------------------------- Reporter: eirnym@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: qt4-mac qt5-mac | ------------------------------+------------------------- Changes (by mf2k@…): * cc: mcalhoun@… (added) * owner: mcalhoun@… => michaelld@… * port: qt5-mac => qt4-mac qt5-mac -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ------------------------------+------------------------- Reporter: eirnym@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: qt4-mac qt5-mac | ------------------------------+------------------------- Changes (by ryandesign@…): * keywords: => haspatch Comment: Replying to [ticket:48516 eirnym@…]:
This is documented in upstream: https://bugreports.qt.io/browse/QTBUG-47641
Yes but that is also a bug you filed, and there isn't consensus there yet that this is the correct solution. -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ------------------------------+------------------------- Reporter: eirnym@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: qt4-mac qt5-mac | ------------------------------+------------------------- Comment (by eirnym@…): I'll post this bug to gerrit for qt5 branch tree, so I don't know if it will be included in qt4 and even qt 5.4.x which is default for macports now. If you review this patch, I has changed int/long to enum constants (yes, it's enum since 10.11) and this is all patch about. -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ------------------------------+------------------------- Reporter: eirnym@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: qt4-mac qt5-mac | ------------------------------+------------------------- Comment (by eirnym@…): This is already fixed very same way in future QT5.5 version, so you can take official patch from repository or take mine. http://code.qt.io/cgit/qt/qtbase.git/commit/src/plugins/platforms/cocoa/qcoc... -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ------------------------------+-------------------------------- Reporter: eirnym@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch elcapitan Port: qt4-mac qt5-mac | ------------------------------+-------------------------------- Changes (by ryandesign@…): * cc: kaveh@… (added) * keywords: haspatch => haspatch elcapitan Comment: Has duplicate #48898. -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ------------------------------+-------------------------------- Reporter: eirnym@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch elcapitan Port: qt4-mac qt5-mac | ------------------------------+-------------------------------- Comment (by michaelld@…): I like this fix. According to Apple https://developer.apple.com/library/prerelease/mac/documentation/Carbon/Refe... , CGEventCreateMouseEvent can return NULL in which case the event should not be used or released. Checking to make sure the event is valid seems reasonable. -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ------------------------------+-------------------------------- Reporter: eirnym@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch elcapitan Port: qt4-mac qt5-mac | ------------------------------+-------------------------------- Comment (by michaelld@…): Done in qt4-mac in r141285. -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#48516: qt5-mac, qt4-mac build error in qcocoacursor.mm ------------------------------+-------------------------------- Reporter: eirnym@… | Owner: michaelld@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: fixed | Keywords: haspatch elcapitan Port: qt4-mac qt5-mac | ------------------------------+-------------------------------- Changes (by mcalhoun@…): * status: new => closed * resolution: => fixed Comment: The upstream fix for Q5 has now released (r142505) -- Ticket URL: <https://trac.macports.org/ticket/48516#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts