[MacPorts] #51158: port submission: arcanist
#51158: port submission: arcanist -------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: arcanist -------------------------+-------------------------------- Developers who are likely to have to deal with the Phabricator collaborative system (used e.g. for code reviews) might be interested in this port that installs the associated `arcanist` (arc) command-line utility. -- Ticket URL: <https://trac.macports.org/ticket/51158> MacPorts <https://www.macports.org/> Ports system for OS X
#51158: port submission: arcanist --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: arcanist | --------------------------+-------------------------------- Comment (by ryandesign@…): There are several things I don't understand about this Portfile. * Why is libphutil a subport of arcanist? Why are these not separate ports? They don't appear to have much Portfile code in common. * Why is the php portgroup used? The portgroup is intended for ports of PHP modules. Are either of these ports PHP modules? Based on the descriptions, I'm assuming they aren't, and that you're merely trying to add a dependency on the latest version of PHP. If so, what you should do instead is to declare variants for each supported version of PHP. * In the destroot phase, you don't need to create the libexec directory; MacPorts does so for you. And you should not use `system` to call `cp -pR`; instead, use the `copy` procedure. -- Ticket URL: <https://trac.macports.org/ticket/51158#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51158: port submission: arcanist --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: arcanist | --------------------------+-------------------------------- Comment (by rjvbertin@…):
* Why is libphutil a subport of arcanist? Why are these not separate ports? They don't appear to have much Portfile code in common.
No, but there also isn't much Portfile code that is *not* in common ;) (esp. if you ignore the checksum lines). Until proof of the contrary, libphutil is something used just by arcanist. Putting both ports in a single portfile makes maintenance easier even if they there isn't much shared code. They'll typically be updated at the same time, for instance.
* Why is the php portgroup used? The portgroup is intended for ports of PHP modules. Are either of these ports PHP modules? Based on the descriptions, I'm assuming they aren't, and that you're merely trying to add a dependency on the latest version of PHP. If so, what you should do instead is to declare variants for each supported version of PHP.
In fact I was hoping to do something as with perl, just declare on whatever is the default version. In reality I could have skipped the whole php dependency because the code runs fine with the system php (that's documented in the official install instructions).
* And you should not use `system` to call `cp -pR`; instead, use the `copy` procedure.
Does that preserve file time stamps and symlinks? If not I could use `file move`. -- Ticket URL: <https://trac.macports.org/ticket/51158#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts