[MacPorts] #48686: [pugixml][1.6][new]
#48686: [pugixml][1.6][new] ------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: pugixml ------------------------+-------------------------------- Basic Portfile for pugixml. -- Ticket URL: <https://trac.macports.org/ticket/48686> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by ryandesign@…): Thanks. The github portgroup should be used. The revision line should be remove. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by nikkoara@…): Replying to [comment:1 ryandesign@…]:
The github portgroup should be used.
There is a line there that indicates the github portgroup. If there is something else that you want me to add, could you please be more specific?
The revision line should be removed.
Done. Thanks! -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by nikkoara@…): Replying to [comment:1 ryandesign@…]:
Thanks.
The github portgroup should be used.
The revision line should be removed
Any updates? Thanks. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by help@…): Portfile.2 works fine for me, please add this port. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by nikkoara@…): Replying to [comment:5 help@…]:
Portfile.2 works fine for me, please add this port.
Guys, I am not sure if you're waiting for me to do something about it. If so, please let me know, explicitly. Otherwise, I am eagerly waiting for this to become part of the official ports. Thanks. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by mf2k@…): Some more comments: - The distfiles line should be removed because that is the default. - An rmd160 checksum should be added. - openmaintainer should be added. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by mojca@…): The first line is probably a matter of `github.setup`, right? (I didn't try it.) I would also suggest adding {{{ cmake.out_of_source yes }}} as mentioned in the ticket #47197. That is not an obligatory part, but something that would be helpful for the future. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by ryandesign@…): Replying to [comment:2 nikkoara@…]:
Replying to [comment:1 ryandesign@…]:
The github portgroup should be used.
There is a line there that indicates the github portgroup. If there is something else that you want me to add, could you please be more specific?
You have included the github portgroup, but are not using it. For instructions on how to use it, read its source code. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by nikkoara@…): Thanks for all feed-back. I think I have addressed them all and I have attached the updated Portfile. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: fixed | Keywords: Port: pugixml | -------------------------+-------------------------------- Changes (by raimue@…): * status: new => closed * resolution: => fixed Comment: Thanks, this looks good now. I made another slight change by swapping the maintainer names. Real persons should be listed before openmaintainer. Committed in r142578. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
#48686: [pugixml][1.6][new] -------------------------+-------------------------------- Reporter: nikkoara@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: fixed | Keywords: Port: pugixml | -------------------------+-------------------------------- Comment (by ryandesign@…): Removed "universal_variant yes" in r142601 because that is the default. -- Ticket URL: <https://trac.macports.org/ticket/48686#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts