[MacPorts] #45527: Add 'guile' variant to GNU Make
#45527: Add 'guile' variant to GNU Make --------------------------------+-------------------------------- Reporter: nicholas.clark@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: MacPorts Future Component: ports | Version: 2.3.2 Keywords: make guile variant | Port: gmake --------------------------------+-------------------------------- As of version 4.0, GNU Make can be built with support for the Guile extension language. Can get get a variant option for installing Make with Guile? I made a replacement Portfile, which is attached to this ticket. -- Ticket URL: <https://trac.macports.org/ticket/45527> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.2 Resolution: | Keywords: haspatch Port: gmake | -------------------------------+------------------------------- Changes (by ryandesign@…): * keywords: make guile variant => haspatch * owner: macports-tickets@… => stuartwesterman@… * type: update => enhancement * milestone: MacPorts Future => Comment: Please attach a unified diff instead. -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.2 Resolution: | Keywords: haspatch Port: gmake | -------------------------------+------------------------------- Comment (by nicholas.clark@…): Replying to [comment:1 ryandesign@…]:
Please attach a unified diff instead.
Done! -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.2 Resolution: | Keywords: haspatch Port: gmake | -------------------------------+------------------------------- Comment (by stuartwesterman@…): This works for me, why hasn't this been patched yet? I'm attaching the diff. Please update and close. -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+--------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch maintainer Port: gmake | -------------------------------+--------------------------------- Changes (by mf2k@…): * keywords: haspatch => haspatch maintainer * version: 2.3.2 => -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+--------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmake | -------------------------------+--------------------------------- Changes (by mf2k@…): * status: new => closed * resolution: => fixed Comment: We were waiting for maintainer (i.e. your) approval. r135940. -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+--------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmake | -------------------------------+--------------------------------- Changes (by mf2k@…): * cc: nicholas.clark@… (removed) -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+--------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmake | -------------------------------+--------------------------------- Changes (by jmr@…): * cc: mf2k@… (added) Comment: That variant has no business setting the entire configure.args string. It should only remove --without-guile and add --with-guile. (Also, what’s with the backtick apostrophe?) -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+--------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmake | -------------------------------+--------------------------------- Comment (by stuartwesterman@…): Oops! Sorry! I'm still learning. I'll try to make the appropriate changes tonight. -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:13> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+--------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmake | -------------------------------+--------------------------------- Comment (by mf2k@…): Replying to [comment:12 jmr@…]:
That variant has no business setting the entire configure.args string. It should only remove --without-guile and add --with-guile. (Also, what’s with the backtick apostrophe?)
That's my fault. I meant to make it a smart quote to make the bbedit macports language work on the Portfile. I can fix it with Stuart's updated variant patch. -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:14> MacPorts <https://www.macports.org/> Ports system for OS X
#45527: gmake: Add 'guile' variant -------------------------------+--------------------------------- Reporter: nicholas.clark@… | Owner: stuartwesterman@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch maintainer Port: gmake | -------------------------------+--------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) Comment: I've made the changes in r136051. -- Ticket URL: <https://trac.macports.org/ticket/45527#comment:15> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts