[MacPorts] #15551: Patch updating dnsmasq to 2.42
#15551: Patch updating dnsmasq to 2.42 ------------------------------------+--------------------------------------- Reporter: davidgilman1@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Submissions Component: ports | Version: 1.6.0 Keywords: dnsmasq | ------------------------------------+--------------------------------------- Attached are patches against the port for dnsmasq to bump to version 2.42. I've also added a startupitem to the Portfile. There is no maintainer for this port. One question though: the package by default installs an example config file. I think it would be appropriate to remind the user to set this up before loading the package into launchd. What would be the best way to do this? (macports is really cool, i had no idea about this startupitem option until just a bit ago.) -- Ticket URL: <http://trac.macports.org/ticket/15551> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15551: Patch updating dnsmasq to 2.42 -------------------------------------+-------------------------------------- Reporter: davidgilman1@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: | Keywords: dnsmasq -------------------------------------+-------------------------------------- Changes (by jmr@macports.org): * cc: davidgilman1@gmail.com (removed) * milestone: Port Submissions => Port Updates Comment: See the squid port for an example of how to handle generating a real config file from a sample one only when the former doesn't exist. Also, please remove the trailing whitespace from the long_description (port lint should warn about that). -- Ticket URL: <http://trac.macports.org/ticket/15551#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15551: Patch updating dnsmasq to 2.42 -------------------------------------+-------------------------------------- Reporter: davidgilman1@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: | Keywords: dnsmasq -------------------------------------+-------------------------------------- Comment (by davidgilman1+macports@gmail.com): Ok, updated the portfile with the post-activate stuff for the config file. The default configuration for dnsmasq is to read and poll /etc/resolv.conf for nameservers. MacOS X updates this file by itself. -- Ticket URL: <http://trac.macports.org/ticket/15551#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15551: Patch updating dnsmasq to 2.42 -------------------------------------+-------------------------------------- Reporter: davidgilman1@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: | Keywords: dnsmasq -------------------------------------+-------------------------------------- Changes (by jmr@macports.org): * cc: jmr@macports.org (added) Comment: The config.h patch will need to be changed. MacPorts also works on platforms where `__APPLE__` is not defined, and files should still be installed into $prefix on them. In the portfile, you don't need a foreach loop for one file. This will do: {{{ post-activate { # Make sure initial conf file is present and setup correctly set f dnsmasq.conf if {![file exists ${prefix}/etc/${f}]} { file copy ${prefix}/etc/${f}.example \ ${prefix}/etc/${f} } } }}} I also notice you're installing it as dnsmasq.conf.sample in the makefile patch but referring to dnsmasq.conf.example in the portfile, so one will need to be changed. -- Ticket URL: <http://trac.macports.org/ticket/15551#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15551: Patch updating dnsmasq to 2.42 -------------------------------------+-------------------------------------- Reporter: davidgilman1@gmail.com | Owner: macports-tickets@lists.macosforge.org Type: enhancement | Status: closed Priority: Normal | Milestone: Port Updates Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: dnsmasq -------------------------------------+-------------------------------------- Changes (by simon@macports.org): * cc: simon@macports.org (added) * status: new => closed * resolution: => fixed Comment: Committed in r37899. Thanks for your help, Simon -- Ticket URL: <http://trac.macports.org/ticket/15551#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts