[MacPorts] #44145: Pythia : Version bump + respect C++ runtime settings
#44145: Pythia : Version bump + respect C++ runtime settings ----------------------+-------------------------------- Reporter: jonesc@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.0 Keywords: | Port: pythia ----------------------+-------------------------------- Hi, The attached diff updates Pythia to the latest version. It also fixes an issue where the port was not fully respecting the c++ runtime settings (for instance if the user was forcing the use of libc++, on pre-Mavericks systems). cheers Chris -- Ticket URL: <https://trac.macports.org/ticket/44145> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Changes (by mojca@…): * keywords: => haspatch * owner: macports-tickets@… => mattiafrancescomoro@… * version: 2.3.0 => * cc: mattiafrancescomoro@… (removed) -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by jonesc@…): Ping ... -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by mojca@…): Does the following work for you? (To avoid one extra "`if`"?) {{{ build.args CC=${configure.cc} \ CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}" }}} Just curious: why do you need `configure.args-append` as opposed to just `configure.args`? Also: your patch doesn't apply cleanly here, but no need to upload a new one this time. -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by jonesc@…): Replying to [comment:5 mojca@…]:
Does the following work for you? (To avoid one extra "`if`"?) {{{ build.args CC=${configure.cc} \ CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}" }}}
I already tried that, and various permutations on the same theme. The bottom line is the pythia makefile is pretty funky, and does support many things you would expect. The only way I was able to get it working was with my patch as provided, which forcibly adds the -stdlib setting to the CXX variable. This seems the only thing the makefile really respects...
Just curious: why do you need `configure.args-append` as opposed to just
`configure.args`? To not override any settings coming from elsewhere. To put the question back, why not use append ? Chris
Also: your patch doesn't apply cleanly here, but no need to upload a new
one this time. -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by jonesc@…):
Also: your patch doesn't apply cleanly here, but no need to upload a new one this time.
No idea about that, it was based on the SVN head at the time I submitted it. Are you sure your local copy is up to date with SVN ? -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by mojca@…): Replying to [comment:6 jonesc@…]:
Replying to [comment:5 mojca@…]:
Does the following work for you? (To avoid one extra "`if`"?) {{{ build.args CC=${configure.cc} \ CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}" }}}
I already tried that, and various permutations on the same theme.
But how is your patch effectively different from my proposal (other than the fact that my proposal would also add `-stdbil=libstdc++` even when that's the default)? I don't understand when your patch would work and mine wouldn't.
The bottom line is the pythia makefile is pretty funky
Is there any chance to ask them to improve the situation a bit?
Just curious: why do you need `configure.args-append` as opposed to just `configure.args`?
To not override any settings coming from elsewhere. To put the question back, why not use append ?
I was curious whether the absence of `-append` actually broke anything for you. I might be wrong, but I would say that append should be used only when there is a reason for it. (Or else change that in all ports.) -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by jonesc@…): Replying to [comment:8 mojca@…]:
Replying to [comment:6 jonesc@…]:
Replying to [comment:5 mojca@…]:
Does the following work for you? (To avoid one extra "`if`"?) {{{ build.args CC=${configure.cc} \ CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}" }}}
I already tried that, and various permutations on the same theme.
But how is your patch effectively different from my proposal (other than the fact that my proposal would also add `-stdbil=libstdc++` even when that's the default)?
I don't understand when your patch would work and mine wouldn't.
They do different things. Look carefully at mine, I redefine the CXX env var. Yours does not.
The bottom line is the pythia makefile is pretty funky
Is there any chance to ask them to improve the situation a bit?
Highly unlikely. I am not enough of a pythia user to really have the energy to go down that route just now ...
Just curious: why do you need `configure.args-append` as opposed to
just `configure.args`?
To not override any settings coming from elsewhere. To put the
question back, why not use append ?
I was curious whether the absence of `-append` actually broke anything for you.
I might be wrong, but I would say that append should be used only when there is a reason for it. (Or else change that in all ports.)
OK -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by jonesc@…): Replying to [comment:9 jonesc@…]:
Replying to [comment:8 mojca@…]:
Replying to [comment:6 jonesc@…]:
Replying to [comment:5 mojca@…]:
Does the following work for you? (To avoid one extra "`if`"?) {{{ build.args CC=${configure.cc} \ CXX="${configure.cxx} -stdlib=${configure.cxx_stdlib}" }}}
I already tried that, and various permutations on the same theme.
But how is your patch effectively different from my proposal (other than the fact that my proposal would also add `-stdbil=libstdc++` even when that's the default)?
I don't understand when your patch would work and mine wouldn't.
They do different things. Look carefully at mine, I redefine the CXX env var. Yours does not.
Sorry... Not enough coffee this morning... I just realised I had cut and pasted your proposal incorrectly. yes, I do eventually agree, yours should do the same, as add -stdbil=libstdc++ as well. That should be fine... Chris -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Changes (by mojca@…): * status: new => closed * resolution: => fixed Comment: Committed in r121647 as maintainer timeout. -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Changes (by mojca@…): * status: closed => reopened * resolution: fixed => Comment: Ah, OK, it seems that I did break something: {{{ /usr/bin/g++-4.2 -stdlib=libstdc++ -O2 -ansi -pedantic -W -Wall -Wshadow -c -Iinclude src/FJcore.cc -o tmp/archive/FJcore.o cc1plus: error: unrecognized command line option "-stdlib=libstdc++" }}} See: * https://build.macports.org/builders/buildports-snowleopard- x86_64/builds/27335 I need help to '''properly''' handle that. -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:12> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by jonesc@…): Replying to [comment:12 mojca@…]:
Ah, OK, it seems that I did break something: {{{ /usr/bin/g++-4.2 -stdlib=libstdc++ -O2 -ansi -pedantic -W -Wall -Wshadow -c -Iinclude src/FJcore.cc -o tmp/archive/FJcore.o cc1plus: error: unrecognized command line option "-stdlib=libstdc++" }}}
See: * https://build.macports.org/builders/buildports-snowleopard- x86_64/builds/27335
I need help to '''properly''' handle that.
Maybe my original if statement is not so bad after all ;) -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by mojca@…): OK, I can fix that. But this means that we probably have a "deeper problem" somewhere anyway. Just before I do another mistake: is there any difference between `CXX="${configure.cxx} -stdlib=libc++"` and `CXX=${configure.cxx}" -stdlib=libc++"`? -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:14> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by jonesc@…): Replying to [comment:14 mojca@…]:
OK, I can fix that. But this means that we probably have a "deeper problem" somewhere anyway.
Just before I do another mistake: is there any difference between `CXX="${configure.cxx} -stdlib=libc++"` and `CXX=${configure.cxx}" -stdlib=libc++"`?
No idea... The second is the one I tested... -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:15> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: reopened Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Comment (by mojca@…): I now committed r121649. -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:16> MacPorts <http://www.macports.org/> Ports system for OS X
#44145: Pythia : Version bump + respect C++ runtime settings -----------------------+----------------------------------- Reporter: jonesc@… | Owner: mattiafrancescomoro@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: pythia | -----------------------+----------------------------------- Changes (by mojca@…): * status: reopened => closed * resolution: => fixed -- Ticket URL: <https://trac.macports.org/ticket/44145#comment:17> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts