[MacPorts] #42378: Upgrade icon programming language to 9.5.1 and check for X11 existence
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence -------------------------+-------------------------------- Reporter: t.tensi@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: upgrade;X11 | Port: icon -------------------------+-------------------------------- Dear all, I have updated the icon portfile to support the following: * icon has been updated to version 9.5.1 * icon can be built with or without X11 graphics support and this has to be configured Therefore I have added an x11 variant that switches between the two modes of configuration. Best regards, Thomas -- Ticket URL: <https://trac.macports.org/ticket/42378> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Changes (by macsforever2000@…): * keywords: upgrade;X11 => * owner: macports-tickets@… => michael.grunewald@… * version: 2.2.1 => Comment: In the future, please use Cc the port maintainers ({{{port info --maintainers icon}}}). [https://guide.macports.org/#development.patches Per the guidelines], please instead attach a unified diff of the Portfile. -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by t.tensi@…): Sorry, I have attached the unified diff. I hope this helps. -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by macsforever2000@…): Thanks. A couple of changes need to be made: 1. Replace the sha1 checksum with the correct sha256 checksum. sha1 and md5 are obsolete and should only be used if upstream provides those. 2. The following code is wrong: {{{ if {[file exists /usr/X11R6/include/X11/Core.h]} { default_variants +x11 } else { default_variants -x11 } }}} I have X11 and that file does not exist for me. I have the Macports {{{xorg-server}}} port installed. -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by t.tensi@…):
1. Replace the sha1 checksum with the correct sha256 checksum. sha1 and md5 are obsolete and should only be used if upstream provides those.
Okay, I had just mimicked the original Portfile that had exactly those checksums. In the attached corrected Portfile there is only sha256 and rmd160.
2. The following code is wrong: [...]
I have X11 and that file does not exist for me. I have the Macports {{{xorg-server}}} port installed.
I now check for the existence of several X-files as mentioned in the Macports guide. Unfortunately I have 10.4 only, so if you could kindly check that on your system this would be fine. -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by macsforever2000@…): That still doesn't work for at least 2 reasons. 1. I'm on Mavericks and there is no "boms" directory in {{{/Library/Receipts/}}}. 1. Even directly in {{{/Library/Receipts/}}}, I have no receipt for X11 because I have it installed via Macports. -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by t.tensi@…): Hi Frank, sorry for the hassle! I have neither a current Intel installation nor X11 on my machine. So it is kind of a blind flight for me, thanks for your patience ;-) Now with the current Portfile - when querying for an X11 installation - I am just checking for the existence of "/Applications/MacPorts/X11.app" . This rules out the standard Apple X11 server, but requires that you have a MacPorts xorg installation. If not, a non-graphics version of icon will be built; this also happens when you do not have X11 at all. Additionally I have added a post-patch modification of the Makedefs file. Currently it blindly assumes that the X11 includes are in "/opt/X11/include" and the X11 libs in "/usr/X11/lib". If we really want to support all kinds of X11 servers, the portfile gets more complicated. As far as I can tell the only port currently depending on "icon" is "noweb" and this does not need any graphics... Best regards, Thomas -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by macsforever2000@…): That's still not quite right. The Macports application directory should really reference the {{{applications_dir}}} variable. But it is perfectly acceptable to not check at all for X11 and make it the default variant. Many other ports do this including {{{inkscape}}} and {{{gimp2}}} (which does not even have an X11 variant because it is simply the default window system). -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by t.tensi@…): Replying to [comment:7 macsforever2000@…]:
[...] The Macports application directory should really reference the {{{applications_dir}}} variable. But it is perfectly acceptable to not check at all for X11 and make it the default variant [like in ] {{{inkscape}}} and {{{gimp2}}}
Hi Frank, I haven't quite got your preference here: * Shall I repair the check by replacing {{{set x11_file /Applications/MacPorts/X11.app}}} with {{{set x11_file ${applications_dir}/X11.app}}} to have a generic solution? or * Shall I remove the check altogether and blindly assume +x11 as the default variant? In my opinion the first approach is safer, but it will definitely miss an Apple installation of X11 and requires a MacPorts installation. Best regards, Thomas -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by macsforever2000@…): I'm saying the latter. Macports allows the user to choose how to install X11 and no other X11 port that I know of checks for it. -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by larryv@…): Also note the difference between depending on MacPorts’ X11 client libraries (e.g., the `xorg-libX11` port) and its X11 server (the `xorg- server` port). -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by t.tensi@…): Dear all, sorry for provoking such a long discussion thread, but now I am a bit lost. Shall I provide a port patch * just for the 9.5.1 update? * Or 9.5.1 plus the variant "x11" with a default of +x11 and no checking? * Or 9.5.1 plus the variant "x11" with an intelligent check for X11 for calculating the default variant? The current productive Portfile blindly assumes X11, because the configuration is always done as {{{make X-Configure}}}. This bombs on Quartz-only configurations (like mine). Here a {{{make Configure}}} should be done instead. My proposal: Michael as the port owner shall decide on how to proceed and I will provide the patch as required. But be aware that I have a PPC Tiger system only, so some verification will be required ;-) Best regards, Thomas -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by macsforever2000@…): Sorry for losing track of this ticket. Please do your 2nd option: "9.5.1 plus the variant "x11" with a default of +x11 and no checking" -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:12> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icon | --------------------------+--------------------------------- Comment (by t.tensi@…): Dear all, I have added the portfile diff as requested by Frank:
... Please do your 2nd option: "9.5.1 plus the variant "x11" with a default of +x11 and no checking"
Best regards, Thomas -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X
#42378: Upgrade icon programming language to 9.5.1 and check for X11 existence --------------------------+--------------------------------- Reporter: t.tensi@… | Owner: michael.grunewald@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: icon | --------------------------+--------------------------------- Changes (by macsforever2000@…): * status: new => closed * resolution: => fixed Comment: Committing with maintainer timeout. r118828. -- Ticket URL: <https://trac.macports.org/ticket/42378#comment:14> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts