#20836: Pureftpd with MySQL ------------------------------------+--------------------------------------- Reporter: lwilbrandt@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: contrib | Version: 1.7.1 Resolution: invalid | Keywords: enhancement, update Port: pureftpd | ------------------------------------+--------------------------------------- Changes (by ryandesign@…): * cc: scott@… (added) * status: new => closed * resolution: => invalid Comment: The pureftpd port already supports mysql5. Your patch is also not acceptable because it changes the formatting of virtually every line of the portfile. In the future please submit diffs that change only what you mean to change. If you want to suggest whitespace changes too, please do so in a separate diff that does nothing but whitespace changes. The port has been renamed pure-ftpd and updated to 1.0.27; see #22920. -- Ticket URL: <http://trac.macports.org/ticket/20836#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS

#20836: Pureftpd with MySQL ------------------------------------+--------------------------------------- Reporter: lwilbrandt@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.7.1 Resolution: invalid | Keywords: enhancement, update Port: pureftpd | ------------------------------------+--------------------------------------- Comment(by scott@…): Replying to [comment:1 ryandesign@…]:

The pureftpd port already supports mysql5. Your patch is also not acceptable because it changes the formatting of virtually every line of the portfile. In the future please submit diffs that change only what you mean to change. If you want to suggest whitespace changes too, please do so in a separate diff that does nothing but whitespace changes.

The port has been renamed pure-ftpd and updated to 1.0.27; see #22920.

Yes, this portfile is entirely different, as I really did not start with the old portfile other than as a point of reference. After talking to the developer, and seeing how the old poerfile installed, what it installed, and where, I made a new portfile. I used bits of the old one, but started with a new file. This is why it was not sent in as a port update, but as a totally new port. Most of my other ports are diffs, unless they are truly new ports, I just felt this one was enough of a change, it should be totally new. Even if I were to diff it, I changed so much, I strongly suspect the dff would have looked about as bad as a line ending change with tab stop change. Sorry about that. -- Ticket URL: <http://trac.macports.org/ticket/20836#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS