#44526: update for xxdiff --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: xxdiff | --------------------------+-------------------------------- Comment (by egall@…): Heh, and I just installed the version that uses qt3 today, too... anyways, the diff should be of the unified type (i.e. `diff -u`). -- Ticket URL: <https://trac.macports.org/ticket/44526#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#44526: xxdiff: update to 4.0 --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: xxdiff | --------------------------+-------------------------------- Comment (by rjvbertin@…): Replying to [comment:1 egall@…]:

Heh, and I just installed the version that uses qt3 today, too... anyways, the diff should be of the unified type (i.e. `diff -u`).

Yeah, the other flavours don't work, eh? Check again O:-) -- Ticket URL: <https://trac.macports.org/ticket/44526#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X

#44526: xxdiff: update to 4.0 --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: xxdiff | --------------------------+-------------------------------- Comment (by rjvbertin@…): Replying to [comment:5 ryandesign@…]:

* One should not both declare "`use_configure no`" and define a "`configure`" block.

OK.

* Do you really need to override the configure phase to run `qmake`? The point of the qmake 1.0 portgroup is to automate that for you.

Have you checked the previous (v3) xxdiff Portfile as well as the port's README.build? A bare-bones qmake won't work.

* One should not "`system "cd ...; ..."`"; one should instead "`system -W ... "..."`".

If you say so ... but I'd prefer to read up on the 'system' documentation before changing something I left unchanged from the v3 xxdiff Portfile (if not only because your suggestion is too ambiguous to my taste; should I understand the syntax is `system -W workDirectory "command args"`?) I'll wait for clarification before uploading a new Portfile diff.

* "`file copy`" can be shortened to "`copy`" and "`file delete`" can be shortened to "`delete`".

OK

* Is there a reason why the documentation needs to be moved to a doc variant? Variants should be added sparingly and when absolutely necessary.

As I tried to indicate, the documentation contains a number of screenshots that take up more space than I considered justified for something I expect no one will ever read. Many ports already provide a +doc variant, I hope exactly to reduce disk space usage. IMHO it's something that should be generalised just like Debian and Ubuntu now split off the documentation of most all packages into separate packages. -- Ticket URL: <https://trac.macports.org/ticket/44526#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X

#44526: xxdiff: update to 4.0 --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: xxdiff | --------------------------+-------------------------------- Comment (by rjvbertin@…): Uploaded the modified Portfile diff. I've added 2 patchfiles, one to correct a minor issue in the parser yacc source, and one to add a few keyboard accelerators (which I'd defined through the SystemPreferences before with a non-MacPorts build of the same source). Building the package on Linux, I discovered that resParser.y must be adapted for use with bison 3.0x . I don't know if/when MacPorts will upgrade bison to the v3 series, but when that happens a patch must be found. I am not familiar with these tools, sadly, or I'd do it right now. -- Ticket URL: <https://trac.macports.org/ticket/44526#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X

#44526: xxdiff: update to 4.0 --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: xxdiff | --------------------------+-------------------------------- Comment (by rjvbertin@…): I see the latter ticket has portfiles for building bison 2.7 and 3.0, but they haven't yet made it to MacPorts? -- Ticket URL: <https://trac.macports.org/ticket/44526#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X