[MacPorts] #51761: Processing: new maintainer and patch
#51761: Processing: new maintainer and patch -------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Keywords: haspatch | Port: processing -------------------------+-------------------------------- processing port referring to old Google code repo. It's now on git. -- Ticket URL: <https://trac.macports.org/ticket/51761> MacPorts <https://www.macports.org/> Ports system for OS X
#51761: Processing: new maintainer and patch --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: processing | --------------------------+-------------------------------- Comment (by mf2k@…): Thanks. Comments: - Do not modify the {{{# $Id:}}} line. It may mean you have edited on old version of the Portfile. - Use the Github portgroup. This will simplify the portfile and be more reliable. - You have changed the license from BSD to GPL. What specific version of the GPL is it licensed under? -- Ticket URL: <https://trac.macports.org/ticket/51761#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51761: Processing: new maintainer and patch --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: processing | --------------------------+-------------------------------- Comment (by ryandesign@…): Using the github portgroup will also help you ensure the port downloads the version of the source code that it claims to offer. (The patch you submitted here so far always downloads the latest version of the code, which we don't allow.) -- Ticket URL: <https://trac.macports.org/ticket/51761#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51761: Processing: new maintainer and patch --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: processing | --------------------------+-------------------------------- Comment (by macports@…): Thanks for the detailed feedback. I've enclosed an updated diff file. * Same `# $Id:` line as original * Use of PortGroup `github 1.0` (and annoying nonstandard paths) * Specifically points to a numbered release (with a similarly annoying prefix) * Clarified that GPL is GPL-2 (https://github.com/processing/processing/blob/master/license.txt) -- Ticket URL: <https://trac.macports.org/ticket/51761#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51761: Processing: new maintainer and patch --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: processing | --------------------------+-------------------------------- Comment (by ryandesign@…): Use of the github portgroup is meant to simplify fetching files from GitHub. You're not meant to have to set github.tag_prefix, github.master_sites, use_zip, distname, distfiles; the defaults of the portgroup should be sufficient. All you should have to set is {{{ github.setup processing processing 3.1.1 processing-0250- }}} -- Ticket URL: <https://trac.macports.org/ticket/51761#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#51761: Processing: new maintainer and patch --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: processing | --------------------------+-------------------------------- Comment (by macports@…): My apologies ryandesign@macport.org, I thought I had exhausted that option (hence my foray into custom paths), but a quick test proved me wrong. The `diff` file has been updated with only the `github.setup` command added and every other option removed. -- Ticket URL: <https://trac.macports.org/ticket/51761#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#51761: Processing: new maintainer and patch --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: haspatch Port: processing | --------------------------+-------------------------------- Changes (by khindenburg@…): * status: new => closed * cc: khindenburg@… (added) * resolution: => fixed Comment: I went ahead and committed your patch - I don't have the correct java installed to verify it installs. Also, I'm not positive the livecheck is correct but that can be fixed later. r152944 -- Ticket URL: <https://trac.macports.org/ticket/51761#comment:6> MacPorts <https://www.macports.org/> Ports system for macOS
#51761: Processing: new maintainer and patch --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: haspatch Port: processing | --------------------------+-------------------------------- Comment (by ryandesign@…): This ticket superseded #49762. The update to 3.2.1 is handled in #52298. -- Ticket URL: <https://trac.macports.org/ticket/51761#comment:7> MacPorts <https://www.macports.org/> Ports system for macOS
#51761: Processing: new maintainer and patch --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: closed Priority: Not set | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: haspatch Port: processing | --------------------------+-------------------------------- Changes (by ryandesign): * cc: khindenburg@… (removed) * cc: kurthindenburg (added) -- Ticket URL: <https://trac.macports.org/ticket/51761#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts