[MacPorts] #47395: Update cantera port for new source
#47395: Update cantera port for new source ------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: cantera ------------------------+-------------------------------- Cantera is moving to GitHub (see https://groups.google.com/forum/?fromgroups#!topic/cantera- users/-JyScUZm0O0) This update just changes the download source. -- Ticket URL: <https://trac.macports.org/ticket/47395> MacPorts <https://www.macports.org/> Ports system for OS X
#47395: Update cantera port for new source --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: maintainer Port: cantera | --------------------------+-------------------------------- Changes (by mf2k@…): * cc: mf2k@… (removed) * keywords: => maintainer * version: 2.3.3 => * type: update => enhancement Comment: Thanks! [https://guide.macports.org/#development.patches Per the guidelines], please use a unified diff format for your patch. -- Ticket URL: <https://trac.macports.org/ticket/47395#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#47395: Update cantera port for new source --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: maintainer Port: cantera | --------------------------+-------------------------------- Comment (by macports@…): Thank you for pointing me to the right paragraph in the guidelines! -- Ticket URL: <https://trac.macports.org/ticket/47395#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#47395: Update cantera port for new source --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: maintainer Port: cantera | --------------------------+-------------------------------- Comment (by larryv@…): I haven’t looked at this at all, but make sure that you don’t have to account for a stealth update here (PortfileRecipes#stealth-updates). -- Ticket URL: <https://trac.macports.org/ticket/47395#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#47395: Update cantera port for new source --------------------------+-------------------------------- Reporter: macports@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: maintainer Port: cantera | --------------------------+-------------------------------- Comment (by macports@…): Thanks, that should definitely be there! I added that line. -- Ticket URL: <https://trac.macports.org/ticket/47395#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#47395: cantera: download from github --------------------------+--------------------------------- Reporter: macports@… | Owner: ryandesign@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: maintainer haspatch Port: cantera | --------------------------+--------------------------------- Changes (by ryandesign@…): * status: new => assigned * owner: macports-tickets@… => ryandesign@… * keywords: maintainer => maintainer haspatch Comment: If a stealth update had occurred, the checksums would have changed, but you did not indicate changed checksums. In fact the checksums do change if we use your patch as-is, because your patch makes the port download from a tarball automatically generated by github from the git repository. Since this project also offers release downloads, we should use those instead, by using `github.tarball_from releases`. The checksums match those from sourceforge, so no stealth update has occurred and there is no need to change the `dist_subdir`. Note also that the `github.setup` line is meant to replace, not supplement, the `name` and `version` lines; you would only keep the `name` or `version` lines if their values differed from those specified in the `github.setup` line, but in this case (and in most cases) they don't. The cantera web site still tells people to download from SourceForge. You might want to let them know they should update that to refer people to github instead. -- Ticket URL: <https://trac.macports.org/ticket/47395#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#47395: cantera: download from github --------------------------+--------------------------------- Reporter: macports@… | Owner: ryandesign@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: maintainer haspatch Port: cantera | --------------------------+--------------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: r134890 -- Ticket URL: <https://trac.macports.org/ticket/47395#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts