[MacPorts] #47231: resolve minor nits with par
#47231: resolve minor nits with par -------------------------+-------------------------------- Reporter: lists@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: haspatch | Port: par -------------------------+-------------------------------- -- Ticket URL: <https://trac.macports.org/ticket/47231> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Changes (by ionic@…): * cc: qbarnes@… (removed) * priority: Normal => Low * owner: macports-tickets@… => qbarnes@… -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by qbarnes@…): Why is it a good idea to change the perms on the executable from 0555 to 0755? -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by lists@…): this was part of a project to add consistency. I was told the 'correct' way was 0755 for my own ports and then just fixed it for all the others too. -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by ionic@…): The default UNIX convention for binaries installed in `bindir` is `0755`. -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by larryv@…): This is correct and can be expressed by simply deleting “-m 555” (xinstall defaults to 0755), but it doesn’t merit a revbump. -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by lists@…): updated diff to not have revbump and remove explicit -m 555 -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by qbarnes@…): Ah, ok. Nothing technically wrong with the way it was other than violating convention. It is a change to bring it into alignment with other packages. In that case, sounds good then, especially with removing the -m option letting xinstall default rather than rehardcoding a new value. So not bumping the rev is simply to save triggering a rebuild for people for a inconsequential update? If so, the patch looks good to me and should be applied. What's the next step? I don't have commit access. -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by ionic@…): Replying to [comment:7 qbarnes@…]:
Ah, ok. Nothing technically wrong with the way it was other than violating convention.
Yep, it's merely an enhancement.
It is a change to bring it into alignment with other packages.
The vast majority of packages either don't specify the mode or use `755`. There are some ports currently installing with `555` for binaries, but that's what these tickets are for (or somesuch.)
In that case, sounds good then, especially with removing the -m option letting xinstall default rather than rehardcoding a new value.
So not bumping the rev is simply to save triggering a rebuild for people for a inconsequential update?
Well, it's for saving triggering a rebuild for people/users... mind you, that's "wrong" to my mind, as the filesystem and `Portfile` will end up diverging, even though this diversion is rather cosmetic and not influencing how a package works. I, personally, still prefer consistency over the comfort of not having to rebuild packages. Most other MacPorts developers seem to think otherwise, however, so I don't really care.
If so, the patch looks good to me and should be applied. What's the next step? I don't have commit access.
I can apply everything, as long as the maintainer gives explicit permission. -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by casr+macports@…): Replying to [comment:8 ionic@…]:
Replying to [comment:7 qbarnes@…]:
If so, the patch looks good to me and should be applied. What's the next step? I don't have commit access.
I can apply everything, as long as the maintainer gives explicit permission.
qbarnes@ is the maintainer so I think that looks like permission to apply the patch :) -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by qbarnes@…): Is there a reason this patch still hasn't be integrated? Does something else I need to do to mark it as ready to get it in the queue? -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: new Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: par | --------------------------+----------------------- Comment (by ionic@…): Yeah... actually, I waited for explicit permission, as said before. I'll take your latest comment as that and will apply the patch (in two steps.) -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:11> MacPorts <https://www.macports.org/> Ports system for OS X
#47231: resolve minor nits with par --------------------------+----------------------- Reporter: lists@… | Owner: qbarnes@… Type: enhancement | Status: closed Priority: Low | Milestone: Component: ports | Version: 2.3.3 Resolution: fixed | Keywords: haspatch Port: par | --------------------------+----------------------- Changes (by ionic@…): * status: new => closed * resolution: => fixed Comment: Modeline in r140221, file permission in r140222. Thanks! -- Ticket URL: <https://trac.macports.org/ticket/47231#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts