[MacPorts] #51607: github-1.0.tcl Expects directory to be unzipped & fails if directory not present
#51607: github-1.0.tcl Expects directory to be unzipped & fails if directory not present ----------------------------+-------------------------------- Reporter: sonofiron@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: github-1.0.tcl | Port: ----------------------------+-------------------------------- Line 174-177 of github-1.0.tcl performs a glob search expecting a non- standardized format of `author-project-*`. Many of the Portfiles i've generated using this PortGroup fail because the extracted contents are simple binaries, with no author or suffix attached. {{{ if {[file exists [glob ${workpath}/${github.author}-${github.project}-*]] && \ [file isdirectory [glob ${workpath}/${github.author}-${github.project}-*]]} { move [glob ${workpath}/${github.author}-${github.project}-*] ${workpath}/${distname} } }}} Logic must be added to be more inclusive of ${workpath}/${github.project} -- Ticket URL: <https://trac.macports.org/ticket/51607> MacPorts <https://www.macports.org/> Ports system for OS X
#51607: github-1.0.tcl Expects directory to be unzipped & fails if directory not present --------------------------+-------------------------------- Reporter: sonofiron@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: github-1.0.tcl Port: | --------------------------+-------------------------------- Changes (by ryandesign@…): * cc: ryandesign@… (added) Comment: Please give a specific example of a github project where this fails. To the best of my knowledge, this should work for all of github's automatically-generated tarballs. -- Ticket URL: <https://trac.macports.org/ticket/51607#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51607: github-1.0.tcl Expects directory to be unzipped & fails if directory not present --------------------------+-------------------------------- Reporter: sonofiron@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: github-1.0.tcl Port: | --------------------------+-------------------------------- Comment (by sonofiron@…): Replying to [comment:1 ryandesign@…]:
Please give a specific example of a github project where this fails. To the best of my knowledge, this should work for all of github's automatically-generated tarballs.
https://github.com/digitalocean/doctl/releases is a good example. I'm new to Portfiles and TCL so I wouldn't be surprised if I'm missing something. I can attach my Portfile if you'd find it helpful. I event went so far as editing github-1.0.tcl locally but so far my modifications have proven futile. -- Ticket URL: <https://trac.macports.org/ticket/51607#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51607: github-1.0.tcl Expects directory to be unzipped & fails if directory not present --------------------------+-------------------------------- Reporter: sonofiron@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: github-1.0.tcl Port: | --------------------------+-------------------------------- Comment (by sonofiron@…): Replying to [comment:2 sonofiron@…]:
Replying to [comment:1 ryandesign@…]:
Please give a specific example of a github project where this fails. To the best of my knowledge, this should work for all of github's automatically-generated tarballs.
https://github.com/digitalocean/doctl/releases is a good example.
I'm new to Portfiles and TCL so I wouldn't be surprised if I'm missing something. I can attach my Portfile if you'd find it helpful. I event went so far as editing github-1.0.tcl locally but so far my modifications have proven futile.
To specify, I've set distfiles to doctl-1.2.0-darwin-10.6-amd64.tar.gz - not the source bundle, perhaps that's my error? -- Ticket URL: <https://trac.macports.org/ticket/51607#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51607: github-1.0.tcl Expects directory to be unzipped & fails if directory not present --------------------------+-------------------------------- Reporter: sonofiron@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: invalid | Keywords: github-1.0.tcl Port: | --------------------------+-------------------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => invalid Comment: If you're going to use a release download, instead of an automatically generated tarball, set: {{{ github.tarball_from releases }}} This and other instructions for using the github portgroup are at the top of the [browser:trunk/dports/_resources/port1.0/group/github-1.0.tcl github portgroup file]. However, this particular file appears to be a pre-compiled binary for a specific version of OS X and a specific processor. MacPorts runs on many versions of OS X and many types of processor, so we would prefer ports that build from source. -- Ticket URL: <https://trac.macports.org/ticket/51607#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#51607: github-1.0.tcl Expects directory to be unzipped & fails if directory not present --------------------------+-------------------------------- Reporter: sonofiron@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: invalid | Keywords: Port: | --------------------------+-------------------------------- Changes (by mf2k@…): * keywords: github-1.0.tcl => -- Ticket URL: <https://trac.macports.org/ticket/51607#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts