[MacPorts] #48986: Unable to Compile libbonoboui
#48986: Unable to Compile libbonoboui ------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: ------------------------+-------------------------------- See attached log -- Ticket URL: <https://trac.macports.org/ticket/48986> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Changes (by ryandesign@…): * port: => libbonoboui Comment: The log says the error is: {{{ :info:build bonobo-control-frame.c:137:1: error: control may reach end of non-void function [-Werror,-Wreturn-type] :info:build } :info:build ^ }}} -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Comment (by rlgarris@…): Yes. It looks like this line in the code is failing: {{{ #if defined (GDK_WINDOWING_X11) id = bonobo_control_window_id_from_x11 ( GDK_WINDOW_XWINDOW (toplev->window)); #elif defined (GDK_WINDOWING_WIN32) id = bonobo_control_window_id_from_x11 ( (guint32) GDK_WINDOW_HWND (toplev->window)); #endif }}} -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Comment (by rlgarris@…): I am on MacOSX Yosemite. -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Comment (by ryandesign@…): Do you perhaps have the gtk2 port installed with the +quartz variant? It builds fine for me with gtk2 installed with the +x11 variant, but that block of code you posted shows that `id` is only being set in X11 and 32-bit Windows windowing environments (i.e. it is not being set when using the Quartz windowing environment). Also, are you using the +x11 variant of the libbonoboui port -- which is enabled by default -- or are you disabling it? -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Comment (by rlgarris@…): Yes I am using the +quartz variant. My goal is to install Gnucash with Quartz. -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Comment (by ryandesign@…): Well it sounds like libbonoboui is not compatible with gtk's quartz mode. You should report that to the developers of libbonoboui so that they can fix it, however there has not been a new release of libbonoboui in over four years, suggesting that the project may be dead and this may never be fixed. -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Comment (by matt@…): I ran into the same issue. The compilation failure happens if both of these macros are disabled. Since there's no block after the else, it thinks the "return id" is the else's statement. I'm not sure if it's functionally correct, but syntactically, the patch I attached addresses the compilation issue. I imagine there's a missing branch for the Quartz case. -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Changes (by mf2k@…): * cc: web@… (added) Comment: Cc reporter of duplicate #50848. -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Comment (by mf2k@…): This may be a duplicate of #41562. -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:9> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Comment (by devans@…): Replying to [comment:9 mf2k@…]:
This may be a duplicate of #41562.
Doesn't look like it. The previous report had to do with format string security and has been fixed for some time although the ticket was not closed. Is now. This one appears to need additional braces in the +quartz case (not X11 and not Windows) to be syntactically correct. See attached patch. However, as mentioned above, the lack of a +quartz #ifdef in this construction is indicative that the upstream developers never really considered the +quartz case. -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:10> MacPorts <https://www.macports.org/> Ports system for OS X
#48986: libbonoboui @2.24.5; error: control may reach end of non-void function --------------------------+-------------------------------- Reporter: rlgarris@… | Owner: macports-tickets@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: fixed | Keywords: Port: libbonoboui | --------------------------+-------------------------------- Changes (by mcalhoun@…): * status: new => closed * resolution: => fixed Comment: Since LibBonoboUI is [https://developer.gnome.org/libbonoboui/ heading towards planned deprecation], it seems doubtful this problem will be worked on upstream.[[BR]] If that is the case, r148009 may be the closest thing we can get to a fix. -- Ticket URL: <https://trac.macports.org/ticket/48986#comment:12> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts