#38755: port submission: xrmc -------------------------------+-------------------------------- Reporter: Tom.Schoonjans@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------------- Comment (by Tom.Schoonjans@…): Replying to [comment:1 egall@…]:

Could the dependency on gcc47 be changed into compiler variants?

Hmmm... not really. The problem is that the package requires g++ with OpenMP v3.0+ support. This rules out the clang++ and g++ compilers that are shipped with Xcode. I could provide variant support for gcc44, gcc45, gcc46 if necessary though if you consider it useful. These compilers also have the required openmp support. -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X

#38755: port submission: xrmc -------------------------------+-------------------------------- Reporter: Tom.Schoonjans@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------------- Comment (by ryandesign@…): Also, since the software is on github, consider using the github portgroup. And if possible, please indicate which version(s) of the GPL are acceptable; not listing a version number implies that any version is acceptable, but it's rare these days to find GPL software that allows GPL version 1 (other than perl-based software which still does). -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X

#38755: port submission: xrmc -------------------------------+-------------------------------- Reporter: Tom.Schoonjans@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------------- Comment (by Tom.Schoonjans@…): Ok, I've added the gcc45 trough gcc48 variants to the file. I didn't add the PortGroups github though: if I understand correctly this would automatically set the master_sites location to tarballs generated by github, which is not what I want to happen. -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X

#38755: port submission: xrmc -------------------------------+-------------------------- Reporter: Tom.Schoonjans@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------- Changes (by ryandesign@…): * status: new => assigned * owner: macports-tickets@… => ryandesign@… Comment: We should not use "then" in the "if" statement. "then" is optional in Tcl "if" statements, and I'm not aware of anywhere else in MacPorts where we use it, so for consistency I'd like to not use it here either. Yes, the github portgroup sets defaults for master_sites, among other things. You're of course free to override that as needed. My hope had been that by using the github portgroup you would get a working livecheck for free, however I see now that's not the case, because the developers unfortunately have not created any tags in their repository, so we'll need to fix the livecheck manually. The github portgroup doesn't seem to provide any benefit right at this time, but I'll add it anyway, since it will make it easier to update the port in the event that github makes global changes in their infrastructure, which they have done before. Since the project's github main page contains no information whatsoever, I've changed the homepage to the github wiki page. The license field is not formatted properly; it should be "GPL-3" not "GPLv3". If later versions of the license are also accepted (which based on the comments in the source code files seems to be the case), then it should be "GPL-3+". The checksums do not match. The portfile was attached April 11 and the distfile was last modified April 23. Perhaps the developers performed a [wiki:PortfileRecipes#stealth-updates stealth update]. I hope they are not in the habit of doing that. I can't check to see if the port builds because its dependency xraylib does not build (#39263). I'm attaching my revised portfile. -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X

#38755: port submission: xrmc -------------------------------+-------------------------- Reporter: Tom.Schoonjans@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------- Comment (by ryandesign@…): Replying to [comment:9 Tom.Schoonjans@…]:

One remark though about the Tcl then statement: I just copy pasted here from the PortfileRecipes as was recommended to me earlier. You may want to change it there as well then.

Thanks, looks like that was recently changed. I changed it back. -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X

#38755: port submission: xrmc -------------------------------+-------------------------- Reporter: Tom.Schoonjans@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------- Comment (by Tom.Schoonjans@…): Hi, Could you give the portfile another look? As far as I know, everything should work now... Thanks, Tom -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X

#38755: port submission: xrmc -------------------------------+-------------------------- Reporter: Tom.Schoonjans@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 2.1.3 Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------- Comment (by Tom.Schoonjans@…): This last version refers to version 6.4.3 of xrmc, which was released two weeks ago. It depends on version 3.0.0 of xraylib that was yesterday updated on Macports. As far as I know it builds and works like a charm... Please consider adding this port to Macports -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:16> MacPorts <http://www.macports.org/> Ports system for OS X

#38755: port submission: xrmc -------------------------------+-------------------------- Reporter: Tom.Schoonjans@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------- Comment (by pixilla@…): ryandesign: Portfile.4 builds for me. Would you like me to commit it? -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:18> MacPorts <http://www.macports.org/> Ports system for OS X

#38755: port submission: xrmc -------------------------------+-------------------------- Reporter: Tom.Schoonjans@… | Owner: ryandesign@… Type: submission | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: xrmc | -------------------------------+-------------------------- Comment (by Tom.Schoonjans@…): Thanks for proceeding with the submission. Feel free to modify the file as you see fit. In the meantime we already released version 6.4.4 by the way. rmd160 9213af0f472c32efc1ed53044c77d67971167f27 sha256 c42c624ea00fd24466e7d1ed559814cdea7c2a2ac7fab40bf73237821960a4be -- Ticket URL: <https://trac.macports.org/ticket/38755#comment:20> MacPorts <http://www.macports.org/> Ports system for OS X