Re: [MacPorts] #40782: wireshark-devel: update to 1.11.0
#40782: wireshark-devel: update to 1.11.0 ------------------------------+----------------------- Reporter: ryandesign@… | Owner: hsivank@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wireshark-devel | ------------------------------+----------------------- Comment (by hsivank@…): Replying to [comment:27 macports@…]:
- Python support has been removed, so those variants are setting configure options which are being ignored. fixed - There is no use setting both cares and adns as default variants, only one of them will be applied. fixed - Setting qt5 as a default variant makes it impossible to build with qt4, since they conflict. An "if" is needed:[[br]] you can use {{{ port install wireshark +qt4 -qt5 }}} - Setting the gtk2 or gtk3 variants builds a qt5 binary AND a gtk binary. Is that intentional? Well, it will be problematic if i provide bundle for each variant ... so it will not be possible anymore - The wireshark port offers variants to enable or disable ipv6 and ssl, This options are not provided by cmake (I ask myself : Is there a reason to disable ipv6 or ssl ?) kerberos5 is enabled by default Kerberos5 breaks build for now, so it is not enabled by default variants gtk2 and portaudio are named x11 and rtp respectively. It may be good to offer compatible variants so that this port can be used as a drop-in replacement once wireshark 1.99 becomes the stable build. i agree, maybe we can make *fake* x11 and rtp variants to support legacy ? - There is an error at line 182, for variant geoip, where you wrote kerberos5 instead. fixed - Variant gtk3 is missing a dependency for port:adwaita-icon-theme, which I had added in my patch.. fixed - "depends_lib port:openssl" on line 40 is reverting the patch made in changeset 139229: https://trac.macports.org/changeset/139229/trunk/dports/net/wireshark- devel/Portfile fixed - These calls:[[br]]"eval xinstall -m 644 [glob ${worksrcpath}/epan/*.h] ${destroot}${prefix}/include/wireshark/epan/"[[br]]should look like this: [[br]]"xinstall -m 644 {*}[glob ${worksrcpath}/epan/*.h] ${destroot}${prefix}/include/wireshark/epan/" (see #48363, comment #1). fixed - As I noted in #48363, comment #9, this patch does not create launchers in the Application folder for the gtk2 and gtk3 variants. to be tested (only tested gtk2) ... - For qt4/qt5, the application launcher created starts with a lowercase w, while the convention is to have it uppercase. fixed
-- Ticket URL: <https://trac.macports.org/ticket/40782#comment:29> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts