[MacPorts] #52023: nano: lint fixes, take maintainer
#52023: nano: lint fixes, take maintainer ----------------------+-------------------------------- Reporter: lists@… | Owner: macports-tickets@… Type: request | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: haspatch | Port: nano ----------------------+-------------------------------- -- Ticket URL: <https://trac.macports.org/ticket/52023> MacPorts <https://www.macports.org/> Ports system for OS X
#52023: nano: lint fixes, take maintainer ----------------------+-------------------------------- Reporter: lists@… | Owner: macports-tickets@… Type: request | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: nano | ----------------------+-------------------------------- Comment (by lists@…): note: this moves a patch file: svn mv nawk.patch patch-nawk.diff -- Ticket URL: <https://trac.macports.org/ticket/52023#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#52023: nano: lint fixes, take maintainer ----------------------+-------------------------------- Reporter: lists@… | Owner: macports-tickets@… Type: request | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: nano | ----------------------+-------------------------------- Comment (by larryv@…): There’s no need to move the patch. -- Ticket URL: <https://trac.macports.org/ticket/52023#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#52023: nano: lint fixes, take maintainer ----------------------+-------------------------------- Reporter: lists@… | Owner: macports-tickets@… Type: request | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: nano | ----------------------+-------------------------------- Comment (by lists@…): Warning: Patchfile nawk.patch does not follow the source patch naming policy "patch-*.diff" from port lint --nitpick but if we just switch to https and add me as maintainer I'd be happy too. -- Ticket URL: <https://trac.macports.org/ticket/52023#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#52023: nano: lint fixes, take maintainer ----------------------+-------------------------------- Reporter: lists@… | Owner: macports-tickets@… Type: request | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: nano | ----------------------+-------------------------------- Comment (by ryandesign@…): Replying to [comment:3 lists@…]:
Warning: Patchfile nawk.patch does not follow the source patch naming policy "patch-*.diff"
Yes, there seems to be a feeling on the mailing lists that we should no longer feel so strictly bound to that naming convention, and many many patchfiles in the repository already do not follow it. As long as the file name is somehow indicative of what the patch does, that's probably good enough. -- Ticket URL: <https://trac.macports.org/ticket/52023#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#52023: nano: lint fixes, take maintainer ----------------------+-------------------------------- Reporter: lists@… | Owner: macports-tickets@… Type: request | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: haspatch Port: nano | ----------------------+-------------------------------- Comment (by raimue@…): As long as we do not change the guide, this is still the active [https://guide.macports.org/#development.patches.source patch naming policy]. I would go with [https://lists.macosforge.org/pipermail/macports- dev/2016-August/033306.html the summary by Mihai]: The file extension `.diff` should still be preferred, but the `<identifier>` mentioned in the guide should be descriptive and not be the filename being patched. -- Ticket URL: <https://trac.macports.org/ticket/52023#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#52023: nano: lint fixes, take maintainer ----------------------+-------------------------------- Reporter: lists@… | Owner: macports-tickets@… Type: request | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: fixed | Keywords: haspatch Port: nano | ----------------------+-------------------------------- Changes (by khindenburg@…): * status: new => closed * resolution: => fixed Comment: done r152458 note I left the patch alone - nawk.patch is a generic patch that I have 18 of them on my system - I don't see a reason to change it -- Ticket URL: <https://trac.macports.org/ticket/52023#comment:6> MacPorts <https://www.macports.org/> Ports system for macOS
participants (1)
-
MacPorts