[MacPorts] #47920: gd2: build fails with libvpx 1.4.0 due to removal of deprecated API.
#47920: gd2: build fails with libvpx 1.4.0 due to removal of deprecated API. ----------------------+-------------------------- Reporter: devans@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: gd2 ----------------------+-------------------------- gd2 still uses the long deprecated libvpx API items IMG_FMT_* PLANE_*. The preferred replacements are VPX_IMG_FMT_* and VPX_PLANE_*. The preferred replacements are available in both the current libvpx 1.3.0 and forthcoming libvpx 1.4.0 (#47907) but the deprecated versions have finally been removed in libvpx 1.4.0 causing the build of gd2 with libvpx 1.4.0 to fail. See attached build log. The attached patch makes the appropriate replacements providing compatibility with both libvpx 1.3.0 and 1.4.0. When building gd2 with libvpx 1.3.0, no installed files are changed in gd2. I'm suggesting that this change be committed now so that when libvpx 1.4.0 is committed only a revbump of gd2 will be necessary. -- Ticket URL: <https://trac.macports.org/ticket/47920> MacPorts <https://www.macports.org/> Ports system for OS X
#47920: gd2: build fails with libvpx 1.4.0 due to removal of deprecated API. -----------------------+-------------------------- Reporter: devans@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: gd2 | -----------------------+-------------------------- Comment (by ryandesign@…): Thanks for finding this before committing libvpx 1.4.0! If you have a working update to 1.4.0 for libvpx, could you attach it to #47907 so I can try it too? -- Ticket URL: <https://trac.macports.org/ticket/47920#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#47920: gd2: build fails with libvpx 1.4.0 due to removal of deprecated API. -----------------------+-------------------------- Reporter: devans@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: gd2 | -----------------------+-------------------------- Comment (by ryandesign@…): Here's the [https://github.com/libgd/libgd/commit/d41eb72cd4545c394578332e5c102dee69e02e... corresponding upstream commit] of this change. -- Ticket URL: <https://trac.macports.org/ticket/47920#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#47920: gd2: build fails with libvpx 1.4.0 due to removal of deprecated API. -----------------------+-------------------------- Reporter: devans@… | Owner: ryandesign@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: gd2 | -----------------------+-------------------------- Comment (by devans@…): Replying to [comment:1 ryandesign@…]:
Thanks for finding this before committing libvpx 1.4.0!
If you have a working update to 1.4.0 for libvpx, could you attach it to #47907 so I can try it too?
Will do if you promise to be gentle in your criticism :-). My current working port is very rough and doesn't work for the +universal case (yet). I just did the minimum to get the port to build in a non-universal case dispensing with the patches and configuration that currently disable the port's own platform specific configuration targets which essentially treat all platforms like a generic x86 build. I'm hoping that letting the port use its own configuration targts will result in more reasonable results on PPC platforms. I'll clean it up a bit and attach as requested. Stand by. -- Ticket URL: <https://trac.macports.org/ticket/47920#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#47920: gd2: build fails with libvpx 1.4.0 due to removal of deprecated API. -----------------------+-------------------------- Reporter: devans@… | Owner: ryandesign@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: fixed | Keywords: haspatch Port: gd2 | -----------------------+-------------------------- Changes (by ryandesign@…): * keywords: => haspatch * status: new => closed * resolution: => fixed Comment: I know you did this already, but just to confirm: On Yosemite, I verified * that gd2 2.1.1 builds with or without the patch with libvpx 1.3.0, * that gd2 2.1.1 has an error without the patch with libvpx 1.4.0, and * that gd2 2.1.1 builds with the patch with libvpx 1.4.0 Committed in r137007. Thanks! -- Ticket URL: <https://trac.macports.org/ticket/47920#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts