[MacPorts] #29770: cmake: remove platform darwin block
#29770: cmake: remove platform darwin block -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: css@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: cmake -------------------------------------+-------------------------------------- The entire `platform darwin` block in the cmake port appears to no longer be needed. See r70407 (in which the platform darwin block was added to do a post-configure reinplace), r70553 (in which the universal variant was fixed by adding code to make and use a list of directories the reinplace would have to be done in), and r73737 (in which the post-configure reinplace was removed but the list-of-directories code was not deleted). -- Ticket URL: <https://trac.macports.org/ticket/29770> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29770: cmake: remove platform darwin block -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: css@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: cmake -------------------------------------+-------------------------------------- Changes (by css@…): * status: new => assigned Comment: I'll check the build results using otool. I need to make sure cmake doesn't pull in the wrong thing. -- Ticket URL: <https://trac.macports.org/ticket/29770#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29770: cmake: remove platform darwin block -------------------------------------+-------------------------------------- Reporter: ryandesign@… | Owner: css@… Type: enhancement | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch | Port: cmake -------------------------------------+-------------------------------------- Comment(by ryandesign@…): How do you mean? The entirety of the `platform darwin` block is a `post- configure` block whose sole purpose is to set a variable called `dirs`, which is never used again in the portfile. I've shown above the reasons why this block came into existence, how that reason no longer exists, and how it was neglected to be removed in a previous revision. Surely it can simply be deleted now. -- Ticket URL: <https://trac.macports.org/ticket/29770#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29770: cmake: remove platform darwin block --------------------------------------+------------------------------------- Reporter: ryandesign@… | Owner: css@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: haspatch Port: cmake | --------------------------------------+------------------------------------- Changes (by css@…): * status: assigned => closed * resolution: => fixed Comment: fixed in r79569 -- Ticket URL: <https://trac.macports.org/ticket/29770#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts