[MacPorts] #44842: [NEW] wkhtmltopdf
#44842: [NEW] wkhtmltopdf ------------------------+-------------------------------- Reporter: jul_bsd@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: | Port: wkhtmltopdf ------------------------+-------------------------------- Convert HTML to PDF using Webkit (QtWebKit) -- Ticket URL: <https://trac.macports.org/ticket/44842> MacPorts <http://www.macports.org/> Ports system for OS X
#44842: [NEW] wkhtmltopdf --------------------------+-------------------------------- Reporter: jul_bsd@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wkhtmltopdf | --------------------------+-------------------------------- Comment (by ryandesign@…): Thanks. Is there a specific reason why you've set the `${name}-devel` subport to use `fetch.type git`? Usually that's unnecessary and undesirable. -- Ticket URL: <https://trac.macports.org/ticket/44842#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#44842: [NEW] wkhtmltopdf --------------------------+-------------------------------- Reporter: jul_bsd@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: wkhtmltopdf | --------------------------+-------------------------------- Comment (by ryandesign@…): I see you've attached a new portfile. Note that Trac does not send email notifications for attachments, so if you want us to notice when you've attached a new file, please also write a comment in the ticket. I see you've changed the ${name}-devel subport to no longer use `fetch.type git`, but now you're setting `master_sites`, `distname`, `use_zip` and `worksrcdir`. As I've explained elsewhere, it's unexpected for you to need to set those when using the github portgroup. Its defaults should work fine. Just run `github.setup`, and possibly `github.tarball_from`. In this case, where you've already set `github.setup` in the main port and want to override some of its values in the subport, just override what you need to: in this case, `git.branch`. Read the documentation in the github portgroup file for more info, though it's probably worth adding a section to the documentation about this unanticipated use case of overriding the version in a devel subport. This new file also has lots of commented-out code and stuff that needs to be fixed. -- Ticket URL: <https://trac.macports.org/ticket/44842#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts