[MacPorts] #49266: R: use compiler portgroup to clean up variants
#49266: R: use compiler portgroup to clean up variants --------------------+--------------------------- Reporter: sean@… | Owner: kjell.konis@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: | Port: --------------------+--------------------------- This cleans up some duplicated code by using the compilers portgroup -- Ticket URL: <https://trac.macports.org/ticket/49266> MacPorts <https://www.macports.org/> Ports system for OS X
#49266: R: use compiler portgroup to clean up variants --------------------------+--------------------------- Reporter: sean@… | Owner: kjell.konis@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: R | --------------------------+--------------------------- Changes (by mf2k@…): * version: 2.3.4 => * type: defect => enhancement * port: => R Comment: Please remember to fill in the Port field. -- Ticket URL: <https://trac.macports.org/ticket/49266#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#49266: R: use compiler portgroup to clean up variants --------------------------+--------------------------- Reporter: sean@… | Owner: kjell.konis@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: R | --------------------------+--------------------------- Comment (by kjell.konis@…): Maintainer here. I am happy with this change except that the default fortran compiler should be gfortran from gcc 4.8 (to match the official CRAN binary release). I wasn't able to find any documentation for compilers portgroup but my guess would be the compilers.setup line should be {{{ compilers.setup require_fortran -gfortran -gcc48 }}} Also, don't forget to bump the revision number. -- Ticket URL: <https://trac.macports.org/ticket/49266#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#49266: R: use compiler portgroup to clean up variants --------------------------+--------------------------- Reporter: sean@… | Owner: kjell.konis@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: R | --------------------------+--------------------------- Comment (by sean@…): Replying to [comment:2 kjell.konis@…]:
Maintainer here. I am happy with this change except that the default fortran compiler should be gfortran from gcc 4.8 (to match the official CRAN binary release). I wasn't able to find any documentation for compilers portgroup but my guess would be the compilers.setup line should be
{{{ compilers.setup require_fortran -gfortran -gcc48 }}}
Also, don't forget to bump the revision number.
Ok, I'll fix that up. Thanks for the review! -- Ticket URL: <https://trac.macports.org/ticket/49266#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#49266: R: use compiler portgroup to clean up variants --------------------------+--------------------------- Reporter: sean@… | Owner: kjell.konis@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: R | --------------------------+--------------------------- Comment (by kjell.konis@…): This bug is duplicated in #49316. The patch there also makes 2 other useful fixes to the Portfile. -- Ticket URL: <https://trac.macports.org/ticket/49266#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#49266: R: use compiler portgroup to clean up variants --------------------------+--------------------------- Reporter: sean@… | Owner: kjell.konis@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: R | --------------------------+--------------------------- Changes (by dstrubbe@…): * status: new => closed * resolution: => fixed Comment: Closed via commit r141379 from duplicate #49316. -- Ticket URL: <https://trac.macports.org/ticket/49266#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts