[MacPorts] #25477: fig2ps version update
#25477: fig2ps version update ---------------------------------+------------------------------------------ Reporter: jjstickel@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: maintainer haspatch | Port: fig2ps ---------------------------------+------------------------------------------ A new version of fig2ps is available. I'll attach a patch for the Portfile. -- Ticket URL: <http://trac.macports.org/ticket/25477> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25477: fig2ps version update ---------------------------------+------------------------------------------ Reporter: jjstickel@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: maintainer haspatch | Port: fig2ps ---------------------------------+------------------------------------------ Changes (by ryandesign@…): * status: new => assigned * owner: macports-tickets@… => ryandesign@… Comment: Thanks, I'll commit it in a moment after I've tested it builds. (Waiting on openmotif...) The modeline you added indicates tabs are to be considered as 2 spaces each. But the existing indentation of the Portfile seems to have assumed that tabs should be considered as 8 spaces each. And the [http://guide.macports.org/chunked/development.practices.html#development.pra... preferred Portfile indentation style] is to indent at 4 spaces and to use spaces, not tabs. May I change the modeline to the standard MacPorts one and reindent the Portfile to this style? -- Ticket URL: <http://trac.macports.org/ticket/25477#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25477: fig2ps version update ---------------------------------+------------------------------------------ Reporter: jjstickel@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: maintainer haspatch | Port: fig2ps ---------------------------------+------------------------------------------ Comment(by jjstickel@…): Replying to [comment:1 ryandesign@…]:
The modeline you added indicates tabs are to be considered as 2 spaces each. But the existing indentation of the Portfile seems to have assumed that tabs should be considered as 8 spaces each. And the [http://guide.macports.org/chunked/development.practices.html#development.pra... preferred Portfile indentation style] is to indent at 4 spaces and to use spaces, not tabs. May I change the modeline to the standard MacPorts one and reindent the Portfile to this style?
The only thing I know about modelines is that I get color syntax highlighting in my emacs editor when they are present! In fact, the automatic indentation doesn't even seem to work for me. I copied that modeline from some other Portfile (don't remember which one). You may change the modeline and adjust the indentation. -- Ticket URL: <http://trac.macports.org/ticket/25477#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25477: fig2ps version update ---------------------------------+------------------------------------------ Reporter: jjstickel@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Keywords: maintainer haspatch | Port: fig2ps ---------------------------------+------------------------------------------ Comment(by ryandesign@…): Thanks, added modeline and updated whitespace in r69358. Now waiting on texlive to build... -- Ticket URL: <http://trac.macports.org/ticket/25477#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#25477: fig2ps version update --------------------------------+------------------------------------------- Reporter: jjstickel@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.1 Resolution: fixed | Keywords: maintainer haspatch Port: fig2ps | --------------------------------+------------------------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Updated to 1.5 in r69366. Also added the "supported_archs noarch" line since this port does not install any architecture-specific files. -- Ticket URL: <http://trac.macports.org/ticket/25477#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts