#39756: Adding runtime dep of yelp to gnome apps breaks +quartz variant -------------------------+---------------------- Reporter: c.herbig@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: yelp | -------------------------+---------------------- Changes (by larryv@…): * cc: devans@… (removed) * owner: macports-tickets@… => devans@… Old description:

Yelp does not compile for +quartz due to some X11 specific calls in the yelp-application.c file. Forcing it as a dependency, even though these programs technically do not depend on it (unless you want to browse the help), breaks the ability to even run them at all.

Specifically it is the function application_uri_resolved, if this could be fixed: {{{ ... ... ... yelp_window_load_uri (window, uri);

gtk_widget_show_all (GTK_WIDGET (window));

/* Metacity no longer does anything useful with gtk_window_present */ gdk_window = gtk_widget_get_window (GTK_WIDGET (window)); if (gdk_window) gdk_x11_window_move_to_current_desktop (gdk_window);

/* Ensure we actually present the window when invoked from the command * line. This is somewhat evil, but the minor evil of Yelp stealing * focus (after you requested it) is outweighed for me by the major * evil of no help window appearing when you click Help. */ if (data->timestamp == 0) data->timestamp = gdk_x11_get_server_time (gtk_widget_get_window (GTK_WIDGET (window)));

gtk_window_present_with_time (GTK_WINDOW (window), data->timestamp);

g_free (data); } }}} then everything should be fine. I would imagine that since a +quartz environment doesn't need metacity, it could perhaps be patched out...

This issue was described here [https://trac.macports.org/ticket/39571 #39571]

New description: Yelp does not compile for +quartz due to some X11 specific calls in the yelp-application.c file. Forcing it as a dependency, even though these programs technically do not depend on it (unless you want to browse the help), breaks the ability to even run them at all. Specifically it is the function application_uri_resolved, if this could be fixed: {{{ ... ... ... yelp_window_load_uri (window, uri); gtk_widget_show_all (GTK_WIDGET (window)); /* Metacity no longer does anything useful with gtk_window_present */ gdk_window = gtk_widget_get_window (GTK_WIDGET (window)); if (gdk_window) gdk_x11_window_move_to_current_desktop (gdk_window); /* Ensure we actually present the window when invoked from the command * line. This is somewhat evil, but the minor evil of Yelp stealing * focus (after you requested it) is outweighed for me by the major * evil of no help window appearing when you click Help. */ if (data->timestamp == 0) data->timestamp = gdk_x11_get_server_time (gtk_widget_get_window (GTK_WIDGET (window))); gtk_window_present_with_time (GTK_WINDOW (window), data->timestamp); g_free (data); } }}} then everything should be fine. I would imagine that since a +quartz environment doesn't need metacity, it could perhaps be patched out... This issue was described here #39571 -- -- Ticket URL: <https://trac.macports.org/ticket/39756#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#39756: Adding runtime dep of yelp to gnome apps breaks +quartz variant -------------------------+---------------------- Reporter: c.herbig@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: yelp | -------------------------+---------------------- Comment (by c.herbig@…): P.S. I can't provide a list at the moment, mainly because it takes soooo long to build, but trying to install webkit-gtk +quartz from a clean macports installation will fail, it still has X11 dependencies in the source code. It also happens if you try to set the configure arguments to compile as webkit-gtk3. -- Ticket URL: <https://trac.macports.org/ticket/39756#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#39756: Adding runtime dep of yelp to gnome apps breaks +quartz variant -------------------------+---------------------- Reporter: c.herbig@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: yelp | -------------------------+---------------------- Comment (by c.herbig@…): Huzzah!!! The problem is solved (except for webkit-gtk still wanting some x11 deps)!!! Step 1, comment out the {{{ #include <gdk/gdkx.h> }}} line in yelp-application.c Step 2, comment out all of this: {{{ /* Metacity no longer does anything useful with gtk_window_present */ gdk_window = gtk_widget_get_window (GTK_WIDGET (window)); if (gdk_window) gdk_x11_window_move_to_current_desktop (gdk_window); /* Ensure we actually present the window when invoked from the command * line. This is somewhat evil, but the minor evil of Yelp stealing * focus (after you requested it) is outweighed for me by the major * evil of no help window appearing when you click Help. */ if (data->timestamp == 0) data->timestamp = gdk_x11_get_server_time (gtk_widget_get_window (GTK_WIDGET (window))); gtk_window_present_with_time (GTK_WINDOW (window), data->timestamp); }}} and insert {{{ gtk_window_present(GTK_WIDGET (window)); }}} and the yelp seems to work just fine. I'll try to make an actual patch tomorrow. -- Ticket URL: <https://trac.macports.org/ticket/39756#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X

#39756: Adding runtime dep of yelp @2.31.6_1 to gnome apps breaks +quartz variant -------------------------+---------------------- Reporter: c.herbig@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: yelp | -------------------------+---------------------- Changes (by larryv@…): * keywords: => haspatch -- Ticket URL: <https://trac.macports.org/ticket/39756#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X

#39756: Adding runtime dep of yelp @2.31.6_1 to gnome apps breaks +quartz variant -------------------------+---------------------- Reporter: c.herbig@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: yelp | -------------------------+---------------------- Comment (by c.herbig@…): P.S. The reason I did not remove the X11 stuff in the quartz variant is because having them is the only way I was able to get webkit-gtk+quartz to compile. So whatever pangox or startup-items installs, it seems to also be needed for webkit-gtk+quartz... -- Ticket URL: <https://trac.macports.org/ticket/39756#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X

#39756: Adding runtime dep of yelp @2.31.6_1 to gnome apps breaks +quartz variant -------------------------+---------------------- Reporter: c.herbig@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: yelp | -------------------------+---------------------- Comment (by c.herbig@…): Although the quick fix patch I submitted gets yelp to work with +quartz, I have since been unable to get webkit-gtk +quartz to compile. The exact same problem reported here #39598. As such, gnome apps +quartz are still broken with depends_run yelp. -- Ticket URL: <https://trac.macports.org/ticket/39756#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X

#39756: Adding runtime dep of yelp @2.31.6_1 to gnome apps breaks +quartz variant -------------------------+---------------------- Reporter: c.herbig@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: yelp | -------------------------+---------------------- Comment (by c.herbig@…): Replying to [comment:14 c.herbig@…]:

I found that the quartz variant can be build using only xorg-libX11 from startup-notification as such: {{{ variant quartz { patchfiles-append patch_quartz-src-yelp-application.c.diff depends_lib-delete port:startup-notification depends_lib-append port:xorg-libX11 } }}} This is still just a quick fix to the actual problem which should ultimately be dealt with upstream. Sorry, I got my projects mixed up, yelp doesn't need an xorg library at all, so both depends_lib part can be removed. It's webkit-gtk +quartz that needs them. I filed a ticket for that problem.

-- Ticket URL: <https://trac.macports.org/ticket/39756#comment:15> MacPorts <http://www.macports.org/> Ports system for OS X

#39756: Adding runtime dep of yelp @2.31.6_1 to gnome apps breaks +quartz variant -------------------------+---------------------- Reporter: c.herbig@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: yelp | -------------------------+---------------------- Comment (by c.herbig@…): The new yelp update (r109403) will probably negate this ticket, and would need new patches anyway. So, I guess this ticket can be closed as unnecessary. -- Ticket URL: <https://trac.macports.org/ticket/39756#comment:17> MacPorts <http://www.macports.org/> Ports system for OS X