[MacPorts] #16993: RFE: have pkgconfig look for x11 libraries
#16993: RFE: have pkgconfig look for x11 libraries -----------------------------------+---------------------------------------- Reporter: mcalhoun@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Keywords: | Port: pkgconfig -----------------------------------+---------------------------------------- May I humbly suggest that pkg-config search in both[[BR]] ${prefix}/lib/pkgconfig and ${x11prefix}/lib/pkgconfig[[BR]] for .pc files. Attached is the proposed change. While looking at the gtk2 port, I noticed that its configure script[[BR]] could not find several X11 libraries it was looking for.[[BR]] I looked into creating MacPorts versions, but I would have ended up porting[[BR]] the entire system. Another example is xrender.[[BR]] I have been testing a newer version.[[BR]] The xrender.pc file depends on x11.pc, which resides in ${x11prefix}/lib/pkgconfig.[[BR]] Were I to make the upgrade, all ports which use xrender would have to set[[BR]] the PKG_CONFIG_PATH variable. All of this is possible, but it seems to me that as a matter of both convenience [[BR]] and elegancy, pkgconfig should search for X11 libraries by default.[[BR]] After all, many ports do in fact use the X11 libraries. The rare port which genuliy does not want to search for X11 libraries can set[[BR]] the PKG_CONFIG_LIBDIR variable. My proposed change sets the search order so MacPorts libraries are found first. -- Ticket URL: <http://trac.macports.org/ticket/16993> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16993: RFE: have pkgconfig look for x11 libraries ------------------------------------+--------------------------------------- Reporter: mcalhoun@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: | Keywords: Port: pkgconfig | ------------------------------------+--------------------------------------- Comment(by afb@macports.org): Another interesting aspect of this is that the pkgconfig of Tiger's X11 is severely limited. Like missing x11.pc itself, which causes some ports trusting pkg-config output to believe that there is no X11 installed... (e.g. xfce4-settings) And yes, Leopard's X11 is better (in that respect). -- Ticket URL: <http://trac.macports.org/ticket/16993#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16993: RFE: have pkgconfig look for x11 libraries ------------------------------------+--------------------------------------- Reporter: mcalhoun@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: | Keywords: Port: pkgconfig | ------------------------------------+--------------------------------------- Comment(by ryandesign@macports.org): Ok, that patch sets these pkgconfig paths: ${prefix}/lib/pkgconfig:${prefix}/share/pkgconfig:${x11prefix}/lib/pkgconfig Why does some software install pkgconfig files into ${prefix}/share/pkgconfig? -- Ticket URL: <http://trac.macports.org/ticket/16993#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16993: RFE: have pkgconfig look for x11 libraries ------------------------------------+--------------------------------------- Reporter: mcalhoun@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: | Keywords: Port: pkgconfig | ------------------------------------+--------------------------------------- Comment(by mcalhoun@macports.org): I did not know this until recently, but the default search path (set in the configure script) for pkg-config is[[BR]] pc_path='${libdir}/pkgconfig:${datadir}/pkgconfig',[[BR]] which is ${prefix}/lib/pkgconfig and ${prefix}/share/pkgconfig. On my machine, gnome-mime-data, gtk-doc, iso-codes, and shared-mime-info install .pc files into ${prefix}/share/pkgconfig. -- Ticket URL: <http://trac.macports.org/ticket/16993#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16993: RFE: have pkgconfig look for x11 libraries ------------------------------------+--------------------------------------- Reporter: mcalhoun@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: new Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: | Keywords: Port: pkgconfig | ------------------------------------+--------------------------------------- Comment(by mcalhoun@macports.org): May I go ahead and commit this patch? -- Ticket URL: <http://trac.macports.org/ticket/16993#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16993: RFE: have pkgconfig look for x11 libraries ------------------------------------+--------------------------------------- Reporter: mcalhoun@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: assigned Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: | Keywords: Port: pkgconfig | ------------------------------------+--------------------------------------- Changes (by ryandesign@macports.org): * status: new => assigned Comment: Sorry -- I'll commit it right now. -- Ticket URL: <http://trac.macports.org/ticket/16993#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16993: RFE: have pkgconfig look for x11 libraries ------------------------------------+--------------------------------------- Reporter: mcalhoun@macports.org | Owner: ryandesign@macports.org Type: enhancement | Status: closed Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: Port: pkgconfig | ------------------------------------+--------------------------------------- Changes (by ryandesign@macports.org): * status: assigned => closed * resolution: => fixed Comment: Committed in r42121. Thanks for the suggestion! -- Ticket URL: <http://trac.macports.org/ticket/16993#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts