[MacPorts] #16361: wireshark-1.0.2 Portfile enhancement request
#16361: wireshark-1.0.2 Portfile enhancement request ---------------------------------+------------------------------------------ Reporter: victor@macports.org | Owner: opendarwin.org@darkart.com Type: enhancement | Status: new Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Keywords: wireshark | ---------------------------------+------------------------------------------ Eric, can you please commit this... port:portaudio may to be added to the Portfile library dependencies of port wireshark in order to enable the rtp_player in wireshark builds. Diff attached. -- Ticket URL: <http://trac.macports.org/ticket/16361> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16361: wireshark-1.0.2 Portfile enhancement request ----------------------------------+----------------------------------------- Reporter: victor@macports.org | Owner: opendarwin.org@darkart.com Type: enhancement | Status: new Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: | Keywords: wireshark ----------------------------------+----------------------------------------- Comment (by ricci@macports.org): Victor- Please do not commit changes to ports that are not marked with 'nomaintainer' or 'openmaintainer' (unless, of course, the 72 hour timeout has passed). In particular, I'm currently working on and testing the addition of the rtp support requested, and I see you've gone and committed the patch you attached to this ticket. I also see that this patch is incomplete (doesn't include the configure args to add portaudio) and you've added it to the default install of wireshark without providing a variant for people to decide if they want to include rtp support. -eric -- Ticket URL: <http://trac.macports.org/ticket/16361#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16361: wireshark-1.0.2 Portfile enhancement request ----------------------------------+----------------------------------------- Reporter: victor@macports.org | Owner: ricci@macports.org Type: enhancement | Status: assigned Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: | Keywords: wireshark ----------------------------------+----------------------------------------- Changes (by ricci@macports.org): * owner: opendarwin.org@darkart.com => ricci@macports.org * status: new => assigned -- Ticket URL: <http://trac.macports.org/ticket/16361#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16361: wireshark-1.0.2 Portfile enhancement request ----------------------------------+----------------------------------------- Reporter: victor@macports.org | Owner: ricci@macports.org Type: enhancement | Status: closed Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: wireshark ----------------------------------+----------------------------------------- Changes (by ricci@macports.org): * status: assigned => closed * resolution: => fixed Comment: resolved in r39476, as a variant (rather than a default). Note: blew away requestor's changes to the Portfile made without authorization (see r39474 and r39475). -- Ticket URL: <http://trac.macports.org/ticket/16361#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#16361: wireshark-1.0.2 Portfile enhancement request ----------------------------------+----------------------------------------- Reporter: victor@macports.org | Owner: ricci@macports.org Type: enhancement | Status: closed Priority: Normal | Milestone: Port Enhancements Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: wireshark ----------------------------------+----------------------------------------- Comment (by victor@macports.org): Eric - Sorry I didn't wait. Honestly, I did check to see who last updated the port and noted it was ricci@macports.org and not the listed maintainer opendarwin.org@darkart.com. I assumed these were different people because of the different addresses--and that the maintainer was not responding and therefore this other person had updated--obviously they're the same person, you. At any rate I think you're making a good suggestion that it be configurable, but FYI portaudio is checked in configure by default and rtp_player is enabled by default in the port already, so making it configurable is always a good thing. I also noted your addition of the other configurable options omitted descriptions, so that's the only reason for my 2nd commit and I had done so before receiving your (this) message I'm responding to now. Trust me, I don't want to take over the wireshark port ;) Please have at it! I was just annoyed it didn't include the portaudio dependency when it was configured and built by default by wireshark and since portaudio was already in the port tree. So thanks for including and sorry for the crossover, it was purely a misunderstanding due to the different e-mail addresses. Thanks, Victor -- Ticket URL: <http://trac.macports.org/ticket/16361#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts