#42600: new port: python/py-scard 1.6.12 ---------------------------------+-------------------------------- Reporter: schmurtz_macport@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | ---------------------------------+-------------------------------- Comment (by ryandesign@…): Thanks. Some remarks: * "categories python" should be removed because the python portgroup sets that for you. * The license field should indicate which version(s) of the LGPL apply. Not specifying the version means that all versions are acceptable, but the homepage says only versions 2.1 or later are acceptable, so the portfile should read "license LGPL-2.1+". * master_sites should be written to [wiki:howto/AvoidRedirects avoid redirects]. * "python.default_version 27" should be removed because that's the default. * There's some confusion in the end of the portfile. The "if {${name} ne ${subport}}" block should be the outer one, enclosing the declaration of the x11 variant and making it the default. We don't want the stub port to have any variants, and we don't want any ports to have variants that do nothing. * I'm unclear on the purpose of the patch. But with or without it, the setup.py seems to hardcode `-arch` flags. We want ports to support the set of `-arch` flags the user requested, which are expressed in the variables ${configure.universal_archflags} (if the universal variant is selected) and ${configure.cc_archflags} (if it isn't). More simply, you can use the [get_canonical_archflags] procedure to get the correct `-arch` flags depending on whether the universal variant is selected or not. Even better, MacPorts already includes this information in the CFLAGS, CXXFLAGS and LDFLAGS environment variables; a properly-written setup.py should make use of those. -- Ticket URL: <https://trac.macports.org/ticket/42600#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#42600: new port: python/py-scard 1.6.12 ---------------------------------+-------------------------------- Reporter: schmurtz_macport@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: py-scard | ---------------------------------+-------------------------------- Changes (by ryandesign@…): * port: => py-scard -- Ticket URL: <https://trac.macports.org/ticket/42600#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X