[MacPorts] #47500: git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number
#47500: git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number -----------------------------+-------------------------------- Reporter: davide.liessi@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: git-flow-devel -----------------------------+-------------------------------- Version comparison (e.g. `port outdated`) is confused by commit ids used as version numbers: the next commit id could be less than the current, in lexicographic order. Using the date of the commit in AAAAMMDD format like e.g. in ffmpeg-devel, frescobaldi-devel, gccxml-devel, ensures that version comparison works as expected. (An update in git-flow-devel is unlikey, given that it hasn't changed since 2012, but I think that it is important to fix this, because you never know.) -- Ticket URL: <https://trac.macports.org/ticket/47500> MacPorts <https://www.macports.org/> Ports system for OS X
#47500: git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number ------------------------------+-------------------------------- Reporter: davide.liessi@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: git-flow-devel | ------------------------------+-------------------------------- Comment (by davide.liessi@…): No need to increase the epoch, since the current version string (commit id) begins with `1` and the new version string (AAAAMMDD date) obviously begins with `2`; also there haven't been any version updates to this subport since its creation. -- Ticket URL: <https://trac.macports.org/ticket/47500#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#47500: git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number ------------------------------+---------------------- Reporter: davide.liessi@… | Owner: ionic@… Type: defect | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: git-flow-devel | ------------------------------+---------------------- Changes (by ionic@…): * owner: macports-tickets@… => ionic@… * status: new => assigned Comment: Maintainer timeout. -- Ticket URL: <https://trac.macports.org/ticket/47500#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#47500: git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number ------------------------------+---------------------- Reporter: davide.liessi@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: git-flow-devel | ------------------------------+---------------------- Changes (by ionic@…): * status: assigned => closed * resolution: => fixed Comment: Committed as r135346. Thanks! -- Ticket URL: <https://trac.macports.org/ticket/47500#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#47500: git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number ------------------------------+---------------------- Reporter: davide.liessi@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: git-flow-devel | ------------------------------+---------------------- Comment (by jason-macports@…): Sorry for not responding in time, and posting to a closed ticket, but I'm not sure defining the version is working as expected, consider: {{{ $ port livecheck git-flow-devel git-flow-devel seems to have been updated (port version: 15aab26490facf285acef56cb5d61025eacb3a69, new version: 1ffb6b1091f05466d3cd27f2da9c532a38586ed5) }}} however * `15aab26 - 2012/09/25 (develop)` * `1ffb6b1 - 2011/02/14 (master)` On a different note, I've been considering removing the `nvie`-based `gitflow` ports, precisely because people seem neither to realize it is effectively abandoned, see https://github.com/nvie/gitflow, nor recognize that the actively developed AVH Edition (https://github.com/petervanderdoes/gitflow) exists. In the case of the ''hash'' driven `git-flow-devel`, while it may be preferred to set `version` in the `Portfile`, if kept, as in `ffmpeg- devel`, it's probably best to simply set `livecheck.type none` My preference is to remove the `nvie` ports, and make the AVH Edition the default. -- Ticket URL: <https://trac.macports.org/ticket/47500#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#47500: git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number ------------------------------+---------------------- Reporter: davide.liessi@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: git-flow-devel | ------------------------------+---------------------- Comment (by davide.liessi@…): I'm sorry I didn't consider livecheck: I should have redefined livecheck (which in this case is defined in the github PortGroup) to do the right thing. Yes, the easiest solution is to set `livecheck.type none`. -- Ticket URL: <https://trac.macports.org/ticket/47500#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#47500: git-flow-devel @15aab26490facf285acef56cb5d61025eacb3a69: should not use the commit id as version number ------------------------------+---------------------- Reporter: davide.liessi@… | Owner: ionic@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: git-flow-devel | ------------------------------+---------------------- Comment (by ryandesign@…): Replying to [comment:5 davide.liessi@…]:
Yes, the easiest solution is to set `livecheck.type none`.
Done in r142456. -- Ticket URL: <https://trac.macports.org/ticket/47500#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts