[MacPorts] #42886: gildas @201402b_1 New port
#42886: gildas @201402b_1 New port -------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Keywords: | Port: -------------------------------+-------------------------------- Please find enclosed a new port for Gildas, a software for radioastronomy. Gildas is widely used by professional radioastronomers, and I think it would be useful to have it included in the MacPort distribution. -- Ticket URL: <https://trac.macports.org/ticket/42886> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by macsforever2000@…): Similar to the my observations in #42887: - The revision line should be deleted because it starts at 0. - Add a sha256 checksum and remove the obsolete sha1 and md5 checksums unless upstream provides them. - Use the compilers portgroup instead of forcing the use of gcc48 for FORTRAN compiling. See the sparskit for an example of how to use it. - Determine and add the correct {{{license}}} -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sebastien.maret@…): Thanks again for the comments. Attached is a revised version of the Portfile. I have a problem though. This port requires that CC, CXX, CPP, and FC/F77 are all from a gcc variant. For example, it's not possible to compile it using CC=clang and FC=gfortran-mp-4.8. How can I modify it so that all compilers come from the same compiler suite? -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by ryandesign@…): Some observations: * The lines "`extract.suffix .tar.gz`" and "`worksrcdir ${distname}`" should be removed because those are the defaults. * You still have "`port:gcc48`" listed as a library dependency. Presumably instead the compilers 1.0 portgroup should be allowed to add the dependency for you. * In the build block, instead of using "`system "cd ${worksrcpath} && ..."`" you should use "`system -W ${worksrcpath} "..."`" * In the destroot block, where you refer to "`${workpath}/gildas-exe- feb14b`", you should instead simplify that to "`${worksrcpath}`". * Instead of using "`system`" to call "`cp -a`", you should just use the Tcl command "`copy`". * Note that "`reinplace`" can accept multiple filenames in a single invocation. So you could simplify the destroot by copying all the files individually, then reinplacing the prefix in them all at once. -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sebastien.maret@…): Thanks for your comments. I've modified the port as you suggested, except for this: Replying to [comment:4 ryandesign@…]:
* In the destroot block, where you refer to "`${workpath}/gildas-exe- feb14b`", you should instead simplify that to "`${worksrcpath}`".
"`${worksrcpath}`" is "`${workpath}/gildas-src-feb14b`", not "`${workpath }/gildas-exe-feb14b`". -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sebastien.maret@…): Attached is a new versions of the Portfile. The new version uses clang++ to compile C++ code, as advised by Ryan and Sean: https://www.mail-archive.com/macports- dev@lists.macosforge.org/msg25967.html -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sebastien.maret@…): New upstream version (apr14b). -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sebastien.maret@…): I've just fixed the version number, which was incorrect (should be 201404b). -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sean@…): I had a chance to try to compile this last night and encountered a lot of problems: - incorrect linking with c++ - opportunistic linking with ATLAS - dependence on gtk+x11 (instead of +quartz) These aren't too bad and I should have a chance to fix them this weekend. For the gtk problem, do you know if quartz can be used instead of X11? -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sean@…): Almost got this to work with gtk+quartz but there's a segfault :-( I fixed a bunch of errors in the package that made clang's cpp fail so now you can use any fortran compiler with any of the C compilers without too much trouble. This should help simply the variants (just need a fortran variants now). Quick question: the portfile references a `bin/sic` file that seems to be missing. Is that needed or not? -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sebastien.maret@…): Replying to [comment:10 sean@…]:
Quick question: the portfile references a `bin/sic` file that seems to be missing. Is that needed or not?
Yes, it is needed. I forgot to attach it. -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sebastien.maret@…): Replying to [comment:9 sean@…]:
- opportunistic linking with ATLAS
Probably this can be fixed by replacing: {{{source admin/gildas-env.sh -c ${configure.fc} -s ${prefix}/include:${prefix}/lib:/System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/Versions/Current/}}} with: {{{source admin/gildas-env.sh -c ${configure.fc} -s /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/Versions/Current/:${prefix}/include:${prefix}/lib}}} -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:12> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sean@…): Replying to [comment:11 sebastien.maret@…]:
Replying to [comment:10 sean@…]:
Quick question: the portfile references a `bin/sic` file that seems to be missing. Is that needed or not?
Yes, it is needed. I forgot to attach it.
Ok, cool, that's what I thought it would be. -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sean@…): Replying to [comment:12 sebastien.maret@…]:
Replying to [comment:9 sean@…]:
- opportunistic linking with ATLAS
Probably this can be fixed by replacing:
{{{source admin/gildas-env.sh -c ${configure.fc} -s ${prefix}/include:${prefix}/lib:/System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/Versions/Current/}}}
with:
{{{source admin/gildas-env.sh -c ${configure.fc} -s /System/Library/Frameworks/Accelerate.framework/Frameworks/vecLib.framework/Versions/Current/:${prefix}/include:${prefix}/lib}}}
Actually, it's tougher than that. In general, one needs to make sure not to use -llapack / -lblas when ATLAS is present, else the linker will pick them up in `${prefix}/lib`. So, I fixed it by replacing all the -llapack and -lblas references with '-framework Accelerate' and '-framework vecLib'. The only wart left is that gtk2 must be installed with the +x11 variant (which conflicts with +quartz). I can attach my patch to make it build with gtk2+quartz but it crashes upon starting up. -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:14> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sean@…): Ok, I think this is now done. I'll test it on my Mavericks machine and then commit it. -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:15> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: Port: | --------------------------------+-------------------------------- Changes (by sean@…): * status: new => closed * resolution: => fixed Comment: Committed in r119194. -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:16> MacPorts <http://www.macports.org/> Ports system for OS X
#42886: gildas @201402b_1 New port --------------------------------+-------------------------------- Reporter: sebastien.maret@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.2.1 Resolution: fixed | Keywords: Port: | --------------------------------+-------------------------------- Comment (by sebastien.maret@…): Thanks for your help with this! -- Ticket URL: <https://trac.macports.org/ticket/42886#comment:17> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts