[MacPorts] #52118: ld64: don't declare variants when they won't work
#52118: ld64: don't declare variants when they won't work -------------------------+------------------------ Reporter: jmr@… | Owner: jeremyhu@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: ld64 -------------------------+------------------------ This way if a user has an unsupported variant selected for whatever reason, they'll just be switched to the current default when upgrading instead of getting an error message that requires manual intervention. The some_llvm_variant_set proc may be slight overkill but it does mean the list of variants only has to be updated in one place. -- Ticket URL: <https://trac.macports.org/ticket/52118> MacPorts <https://www.macports.org/> Ports system for OS X
#52118: ld64: don't declare variants when they won't work --------------------------+------------------------ Reporter: jmr@… | Owner: jeremyhu@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: ld64 | --------------------------+------------------------ Comment (by jeremyhu@…): That would be great if it worked, but doing so will result in the llvm33 and llvm34 variants not being declared in the PortIndex when generated on newer systems. -- Ticket URL: <https://trac.macports.org/ticket/52118#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#52118: ld64: don't declare variants when they won't work --------------------------+------------------------ Reporter: jmr@… | Owner: jeremyhu@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: ld64 | --------------------------+------------------------ Comment (by jeremyhu@…): From IRC, it turns out each platform has a separate index, so that should work out fine. Unfortunately, this doesn't quite work because the system sees `[ldelete $all_llvm_variants $variantname]` as a single variant. Eg: {{{ Warning: Variant llvm38 conflicts with non-existing variant llvm39 llvmdev }}} r152081 addresses the main issue (note that the accidental change to wiggle was reverted in the following commit), but I'd prefer to generate the variants instead of listing them all out if that's possible. Leaving this open to track taking the spirit of the rest of the change. -- Ticket URL: <https://trac.macports.org/ticket/52118#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#52118: ld64: don't declare variants when they won't work --------------------------+------------------------ Reporter: jmr@… | Owner: jeremyhu@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: ld64 | --------------------------+------------------------ Changes (by jmr@…): * status: new => closed * resolution: => fixed Comment: r152084 -- Ticket URL: <https://trac.macports.org/ticket/52118#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#52118: ld64: don't declare variants when they won't work --------------------------+------------------------ Reporter: jmr@… | Owner: jeremyhu@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: ld64 | --------------------------+------------------------ Comment (by jeremyhu@…): And r152086 for cctools -- Ticket URL: <https://trac.macports.org/ticket/52118#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts