[MacPorts] #33849: update port: py26-openbabel
#33849: update port: py26-openbabel -----------------------------------+---------------------------------------- Reporter: atenderholt@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: | Port: py26-openbabel -----------------------------------+---------------------------------------- Update port to match version of newest OpenBabel (2.3.0) in MacPorts. Based on the py27-openbabel Portfile (ticket #33848). Note that I have not tested this with Python 2.6, but the Python 2.7 version works fine. -- Ticket URL: <https://trac.macports.org/ticket/33849> MacPorts <http://www.macports.org/> Ports system for Mac OS
#33849: py26-openbabel: update to 2.3.0 -----------------------------------+---------------------------------------- Reporter: atenderholt@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: haspatch | Port: py26-openbabel -----------------------------------+---------------------------------------- Changes (by ryandesign@…): * keywords: => haspatch Comment: In the future, for existing ports, please supply a unified diff of your changes instead of a complete new port; that makes it easier to review your proposed changes. `-I${prefix}/include/openbabel-2.0` does not belong in build.target. It might belong in build.args but I'm still uncomfortable about hardcoding that value, specifically the 2.0 version number which seems likely to change in future versions of openbabel. Is there a way to ask openbabel for this value -- maybe via a config script or pkg-config? -- Ticket URL: <https://trac.macports.org/ticket/33849#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#33849: py26-openbabel: update to 2.3.0 -----------------------------------+---------------------------------------- Reporter: atenderholt@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Keywords: haspatch | Port: py26-openbabel -----------------------------------+---------------------------------------- Comment(by atenderholt@…): Replying to [comment:1 ryandesign@…]:
In the future, for existing ports, please supply a unified diff of your changes instead of a complete new port; that makes it easier to review your proposed changes.
Thanks for the tip, I completely forgot that a diff is more appropriate.
`-I${prefix}/include/openbabel-2.0` does not belong in build.target. It might belong in build.args but I'm still uncomfortable about hardcoding that value, specifically the 2.0 version number which seems likely to change in future versions of openbabel. Is there a way to ask openbabel for this value -- maybe via a config script or pkg-config?
I'm not sure why, but pkg-config expects openbabel-2.0 to be passed to it instead of openbabel or openbabel-${version}. Nothing in the openbabel Portfile suggests why this is the case. What is the best way to proceed? -- Ticket URL: <https://trac.macports.org/ticket/33849#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#33849: py26-openbabel: update to 2.3.0 ------------------------------------+--------------------------------------- Reporter: atenderholt@… | Owner: macports-tickets@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.0.4 Resolution: duplicate | Keywords: haspatch Port: py26-openbabel | ------------------------------------+--------------------------------------- Changes (by ryandesign@…): * status: new => closed * cc: ryandesign@… (added) * resolution: => duplicate Comment: A new unified py-openbabel port has been submitted in #33848 which supersedes this ticket. -- Ticket URL: <https://trac.macports.org/ticket/33849#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts