[MacPorts] #36397: jgraph-8.3 fails to compile with clang
#36397: jgraph-8.3 fails to compile with clang -----------------------------+-------------------------------- Reporter: brett.higgins@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Keywords: | Port: jgraph -----------------------------+-------------------------------- Short version: clang doesn't like old-style C function definitions. configure.cc gives clang on Mountain Lion (maybe on others?), so jgraph fails to compile. Lots of warnings like this: {{{ edit.c:683:1: warning: type specifier missing, defaults to 'int' [-Wimplicit-int] edit_hash_label(a) ^~~~~~~~~~~~~~~ }}} and resulting errors like this: {{{ edit.c:700:40: error: non-void function 'edit_hash_label' should return a value [-Wreturn-type] if ((s = getlabel()) == CNULL) return; ^ }}} Adding {{{ configure.compiler gcc }}} to the Portfile resolves the issue. (Alternative fix would be to patch all the old-style definitions; obviously more laborious.) -- Ticket URL: <https://trac.macports.org/ticket/36397> MacPorts <http://www.macports.org/> Ports system for Mac OS
#36397: jgraph-8.3 fails to compile with clang ------------------------------+------------------- Reporter: brett.higgins@… | Owner: s@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: clang Port: jgraph | ------------------------------+------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => s@… * keywords: => clang Comment: Replying to [ticket:36397 brett.higgins@…]:
configure.cc gives clang on Mountain Lion (maybe on others?)
On Xcode 4.2 and up.
Adding {{{ configure.compiler gcc }}} to the Portfile resolves the issue. (Alternative fix would be to patch all the old-style definitions; obviously more laborious.)
{{{ compiler.blacklist clang }}} is what we would want to put, if we cannot fix it to compile with clang. -- Ticket URL: <https://trac.macports.org/ticket/36397#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#36397: jgraph-8.3 fails to compile with clang ------------------------------+------------------- Reporter: brett.higgins@… | Owner: s@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: clang Port: jgraph | ------------------------------+------------------- Comment (by s@…): I've uploaded a bunch of patches that allow jgraph to be compiled without error. The new Portfile should fix ticket #36405 as well. I've also changed my email address to match what I use for trac. -- Ticket URL: <https://trac.macports.org/ticket/36397#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#36397: jgraph-8.3 fails to compile with clang ------------------------------+------------------- Reporter: brett.higgins@… | Owner: s@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: clang Port: jgraph | ------------------------------+------------------- Comment (by macsforever2000@…): Please instead attach a unified diff of the portfile so we can see what changes you made. -- Ticket URL: <https://trac.macports.org/ticket/36397#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#36397: jgraph-8.3 fails to compile with clang ------------------------------+------------------- Reporter: brett.higgins@… | Owner: s@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: clang Port: jgraph | ------------------------------+------------------- Comment (by s@…): Replying to [comment:3 macsforever2000@…]:
Please instead attach a unified diff of the portfile so we can see what changes you made. Done.
-- Ticket URL: <https://trac.macports.org/ticket/36397#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#36397: jgraph-8.3 fails to compile with clang ------------------------------+------------------- Reporter: brett.higgins@… | Owner: s@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: clang Port: jgraph | ------------------------------+------------------- Comment (by ryandesign@…): Replying to [comment:2 s@…]:
The new Portfile should fix ticket #36405 as well.
I applied that portion of the patch in r98258. -- Ticket URL: <https://trac.macports.org/ticket/36397#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#36397: jgraph-8.3 fails to compile with clang ------------------------------+-------------------- Reporter: brett.higgins@… | Owner: s@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: fixed | Keywords: clang Port: jgraph | ------------------------------+-------------------- Changes (by ryandesign@…): * status: new => closed * resolution: => fixed Comment: Committed in r98260 and r98261. -- Ticket URL: <https://trac.macports.org/ticket/36397#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts