#37471: NEW: py-stfio -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: request | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: py-stfio | -------------------------+-------------------------------- Changes (by ryandesign@…): * version: 2.1.2 => * type: submission => request -- Ticket URL: <https://trac.macports.org/ticket/37471#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS

#37471: NEW: py-stfio -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: py-stfio | -------------------------+-------------------------------- Comment (by christsc@…): Thanks for your review. All addressed in https://code.google.com/p/stimfit/source/detail?r=a3f9b9be56d8 Replying to [comment:2 ryandesign@…]:

Some questions and comments about the port at the URL:

* "`license GPL`": Can you indicate the license version(s)? e.g. "GPL-2" or maybe "GPL-3+".

Fixed.

* "`master_sites https://stimfit.googlecode.com/files/ file:///Users/cs/stimfit/build/release/`": "`master_sites googlecode:stimfit`" is preferred; listing a `file:///` URL in master_sites doesn't make sense

How neat is that. Fixed.

* "`supported_archs x86_64 i386`": for what reason does this software not work on PowerPC?

It hasn't been tested on ppc, and there's good reason to believe that big endianness may cause trouble.

* "`python.default_version 27`" can be omitted because that is the default

Fixed.

* "`configure.args PYTHON=${python.bin}`": "`configure.python ${python.bin}`" is preferred

Fixed.

* "`depends_lib port:swig-python`": is it really a library dependency? Usually swig is only used at build time, to build some kind of language bindings.

Fixed. The updated Portfile is available here: https://stimfit.googlecode.com/git/macosx/macports/python/py- stfio/Portfile -- Ticket URL: <https://trac.macports.org/ticket/37471#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS

#37471: NEW: py-stfio -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: py-stfio | -------------------------+-------------------------------- Comment (by christsc@…): Thanks for your review. Replying to [comment:18 ciserlohn@…]:

Some remarks:

- as the software is licensed under the GPL the port should include a copy in {{{${prefix}/share/doc/py-stfio/}}} (see https://www.gnu.org/licenses/gpl-faq.html#WhyMustIInclude).

Fixed in [https://code.google.com/p/stimfit/source/detail?r=45f538cbfddc r45f538cbfddc].

- there are no .pyc files included. Most py-* ports include them because they can't be generated afterwards (the installation directory is typically read-only for ordinary users).

Fixed in [https://code.google.com/p/stimfit/source/detail?r=609ada02fd6a r609ada02fd6a]. This is useful for other platforms as well.

- the debian packages includes {{{hdf5tools.py}}}. The port does not (I don't know if this is revelvant).

hdf5tools.py should not be part of the latest versions of py-stfio. -- Ticket URL: <https://trac.macports.org/ticket/37471#comment:21> MacPorts <http://www.macports.org/> Ports system for OS X

#37471: NEW: py-stfio -------------------------+-------------------------------- Reporter: christsc@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: py-stfio | -------------------------+-------------------------------- Comment (by christsc@…): Replying to [comment:22 ciserlohn@…]:

Replying to [comment:21 christsc@…]:

...

Thanks for your review.

Replying to [comment:18 ciserlohn@…]:

...

Some remarks:

- as the software is licensed under the GPL the port should include a copy in {{{${prefix}/share/doc/py-stfio/}}} (see https://www.gnu.org/licenses/gpl-faq.html#WhyMustIInclude).

Fixed in [https://code.google.com/p/stimfit/source/detail?r=45f538cbfddc r45f538cbfddc].

The port now installs {{{${prefix}/share/doc/py27-stfio/copyright}}} which is good, but it does not include the full text of the GPL:

{{{ On Debian systems, the full text of the GNU General Public License version 2 can be found in the file `/usr/share/common-licenses/GPL-2'. }}}

We're not on debian so the aforementioned file does not exists. Please include a full text version of the GPL.

Fixed in [https://code.google.com/p/stimfit/source/detail?r=948c6eac5c8a r948c6eac5c8a]. This also addresses the [https://trac.macports.org/ticket/33575#comment:21 remaining comment] in ticket #33575.

Apart from that I think the port is ready for inclusion.

Thanks -- Ticket URL: <https://trac.macports.org/ticket/37471#comment:23> MacPorts <http://www.macports.org/> Ports system for OS X