[MacPorts] #50327: pfft: Build without --disable-shared
#50327: pfft: Build without --disable-shared -----------------------------+-------------------------------- Reporter: michael-lists@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: | Port: pfft -----------------------------+-------------------------------- The pfft port builds just fine without the ''--disable-shared'' configure flag. The patch below removes it, which is useful for anyone who wants to use PFFT as a dynamic library. Because PFFT does not link to FFTW3 by itself, FFTW3 needs to be explicitly added to the ''LDFLAGS''. {{{ --- ports/math/pfft/Portfile 2015-10-21 17:30:57.000000000 +0200 +++ ports/math/pfft/Portfile 2016-01-14 15:46:15.000000000 +0100 @@ -44,7 +44,7 @@ } configure.args-append MPICC=${mpi.cc} MPIFC=${mpi.f90} \ - CPPFLAGS=-I${prefix}/include LDFLAGS=-L${prefix} --disable-shared + CPPFLAGS=-I${prefix}/include LDFLAGS="-L${prefix} -lfftw3 -lfftw3_mpi" } livecheck.type regex }}} -- Ticket URL: <https://trac.macports.org/ticket/50327> MacPorts <https://www.macports.org/> Ports system for OS X
#50327: pfft: Build without --disable-shared ------------------------------+------------------------ Reporter: michael-lists@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: pfft | ------------------------------+------------------------ Changes (by mf2k@…): * cc: dstrubbe@… (removed) * owner: macports-tickets@… => dstrubbe@… * version: 2.3.4 => -- Ticket URL: <https://trac.macports.org/ticket/50327#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#50327: pfft: Build without --disable-shared ------------------------------+------------------------ Reporter: michael-lists@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: pfft | ------------------------------+------------------------ Comment (by dstrubbe@…): What do you mean by this? "Because PFFT does not link to FFTW3 by itself, FFTW3 needs to be explicitly added to the LDFLAGS." What sort of actual or potential problem is there in the current situation? -- Ticket URL: <https://trac.macports.org/ticket/50327#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#50327: pfft: Build without --disable-shared ------------------------------+------------------------ Reporter: michael-lists@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pfft | ------------------------------+------------------------ Changes (by dstrubbe@…): * keywords: => haspatch -- Ticket URL: <https://trac.macports.org/ticket/50327#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#50327: pfft: Build without --disable-shared ------------------------------+------------------------ Reporter: michael-lists@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pfft | ------------------------------+------------------------ Comment (by michael-lists@…): If you don't add "-lfftw3 -lfftw3_mpi", then you get unresolved FFTW3 symbols when libpfft.dylib is made. -- Ticket URL: <https://trac.macports.org/ticket/50327#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#50327: pfft: Build without --disable-shared ------------------------------+------------------------ Reporter: michael-lists@… | Owner: dstrubbe@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: pfft | ------------------------------+------------------------ Comment (by sean@…): Yes, we should be using shared libraries when possible. Look at my work for `SuperLU`, `MUMPS`, and `SuiteSparse` for example. -- Ticket URL: <https://trac.macports.org/ticket/50327#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#50327: pfft: Build without --disable-shared ------------------------------+------------------------ Reporter: michael-lists@… | Owner: dstrubbe@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: pfft | ------------------------------+------------------------ Changes (by dstrubbe@…): * status: new => closed * resolution: => fixed Comment: Thanks for the patch. Committed in r144662. -- Ticket URL: <https://trac.macports.org/ticket/50327#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts