#37797: New port: portfile-gen ---------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: portfile-gen | ---------------------------+-------------------------------- Comment (by egall@…): OK, new portfile attached. Replying to [comment:1 ryandesign@…]:

Thanks. A few observations:

* The Portfile says the version is "0.1.0 " but the script says it's "0.1".

Changed to 0.2 actually, seeing as you bumped it in r102075. Since you were the last one to edit it, I added you as a maintainer, too (I hope that's okay with you)

* There is no distfile, so "dist_subdir" is not needed.

Removed.

* A dependency on port:tcl is added, but it is not used; either patch the script to use MacPorts Tcl in the first line, or remove the dependency. Assuming the script doesn't do anything that requires Tcl newer than 8.4, I'd favor the latter, since MacPorts itself uses the system's Tcl, not MacPorts Tcl.

Removed.

* Indentations should be at multiples of 4 spaces.

Too lazy to fix this one myself... feel free to change it yourself though. -- Ticket URL: <https://trac.macports.org/ticket/37797#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS

#37797: New port: portfile-gen ---------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: portfile-gen | ---------------------------+-------------------------------- Comment (by egall@…): Replying to [comment:3 egall@…]:

(Note to self: need to update port for MacPorts 2.3.0) Actually upon double-checking this, the port uses the system tclsh (i.e. `/usr/bin/tclsh`), so it does '''not''' actually need to be updated for MacPorts 2.3.0. I am still attaching a new Portfile that bumps it to the latest revision in which it was modified (i.e. r114218) though.

-- Ticket URL: <https://trac.macports.org/ticket/37797#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X

#37797: New port: portfile-gen ---------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.1.2 Resolution: | Keywords: Port: portfile-gen | ---------------------------+-------------------------------- Comment (by egall@…): Replying to [comment:5 mf2k@…]:

Some notes: - The revision line needs to be deleted. I agree that the revision needs to be deleted for trunk, but I need to keep the revision in my local repository to make sure that MacPorts can tell that it is newer than previously versions that I have installed. Feel free to remove the revision line when committing it to trunk though. - I don't see the point of the ui_debug line in the empty build phase. Many ports lack a build phase and don't say as much. Yeah, I used to leave the build phase completely empty previously, too, based on the other ports that did as such, but I just kind of felt uncomfortable leaving it like that. Doing it this way makes it clearer that the build phase is being skipped intentionally. It is mostly just a personal taste thing though, so feel free to remove the line when committing it to trunk.

-- Ticket URL: <https://trac.macports.org/ticket/37797#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X