[MacPorts] #29622: fossil: fix #29591, don't build windows specific files, remove -O2 CFLAG
#29622: fossil: fix #29591, don't build windows specific files, remove -O2 CFLAG --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch maintainer | Port: fossil --------------------------------------+------------------------------------- changes: * include upstream fix for #29591 * don't create the windows specific make files * remove -O2 from ${configure.cflags} as it is inconsistence with the -Os flag set by the makefile -- Ticket URL: <https://trac.macports.org/ticket/29622> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29622: fossil: fix #29591, don't build windows specific files, remove -O2 CFLAG --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch maintainer | Port: fossil --------------------------------------+------------------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => ryandesign@… * status: new => assigned Comment: Replying to [ticket:29622 ciserlohn@…]:
* remove -O2 from ${configure.cflags} as it is inconsistence with the -Os flag set by the makefile
I see that they use `-Os`, and then MacPorts adds its `-O2` after, which should mean `-O2` takes precedence. The port seemed to build fine with `-O2`... are you saying the program will work better with `-Os`? If so, I think the preferred way to indicate this is not: {{{ configure.cflags-delete -O2 }}} but instead: {{{ configure.optflags -Os }}} -- Ticket URL: <https://trac.macports.org/ticket/29622#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29622: fossil: fix #29591, don't build windows specific files, remove -O2 CFLAG --------------------------------------+------------------------------------- Reporter: ciserlohn@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Keywords: haspatch maintainer | Port: fossil --------------------------------------+------------------------------------- Comment(by ciserlohn@…): Replying to [comment:1 ryandesign@…]:
Replying to [ticket:29622 ciserlohn@…]:
* remove -O2 from ${configure.cflags} as it is inconsistence with the -Os flag set by the makefile
I see that they use `-Os`, and then MacPorts adds its `-O2` after, which should mean `-O2` takes precedence. The port seemed to build fine with `-O2`... are you saying the program will work better with `-Os`?
Not that I'm aware of. It is only a precautionary measure to not hit problems with -O2 as the upstream developer test their versions with -Os. Additionally they strive to avoid bloat. I think -Os is well-suited for that goal - the actual file sizes are 1.5M for -Os vs. 1.6M for -O2 and 2.8M vs. 3.0M for the universal variant.
If so, I think the preferred way to indicate this is not: {{{ configure.cflags-delete -O2 }}} but instead: {{{ configure.optflags -Os }}}
Yes, configure.optflags is the right place, but wouldn't be {{{ configure.optflags-delete -O2 }}} the right thing to do. Otherwise we would add -Os twice. Anyway, I added patches for all three options, feel free to pick the one you think is the most appropriate. -- Ticket URL: <https://trac.macports.org/ticket/29622#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#29622: fossil: fix #29591, don't build windows specific files, remove -O2 CFLAG ---------------------------------------+------------------------------------ Reporter: ciserlohn@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.9.2 Resolution: fixed | Keywords: haspatch maintainer Port: fossil | ---------------------------------------+------------------------------------ Changes (by ciserlohn@…): * status: assigned => closed * resolution: => fixed Comment: fixed in r79813 -- Ticket URL: <https://trac.macports.org/ticket/29622#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts