[MacPorts] #15707: vobcopy lfs not enabled
#15707: vobcopy lfs not enabled -----------------------------+---------------------------------------------- Reporter: tom.duck@dal.ca | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.6.0 Keywords: vobcopy lfs | -----------------------------+---------------------------------------------- vobcopy does not have large file support (lfs) enabled under 10.4 Tiger. Witness what happens when I try to vobcopy to one large file: -- $ vobcopy -l [Error] Wrong option. Vobcopy 1.1.0 - GPL Copyright (c) 2001 - 2007 robos@muon.de Usage: vobcopy [-m (mirror)] [-i /path/to/the/mounted/dvd/] [-n title-number] [-t <your name for the dvd>] [-o /path/to/output-dir/ (can be "stdout" or "-")] [-f (force output)] [-V (version)] [-v (verbose)] [-v -v (create log-file)] [-h (this here ;-)] [-I (infos about title, chapters and angles on the dvd)] [-1/path/to/second/output/dir/] [-2/.../third/..] [-3/../] [-4 /../] [-b <skip-size-at-beginning[bkmg]>] [-e <skip-size-at-end[bkmg]>] [-O <single_file_name1,single_file_name2, ...>] [-q (quiet)] [-w <watchdog-minutes>] [-F <fast-factor:1..64>] -- Perusal of the source shows that the option exists, but for some reason it is not compiled in. -- Ticket URL: <http://trac.macports.org/ticket/15707> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled ------------------------------+--------------------------------------------- Reporter: tom.duck@dal.ca | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: vobcopy lfs ------------------------------+--------------------------------------------- Changes (by jmr@macports.org): * cc: 0booo5b02@sneakemail.com (added) * milestone: => Port Bugs Comment: Cc maintainer. -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled ------------------------------+--------------------------------------------- Reporter: tom.duck@dal.ca | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: vobcopy lfs ------------------------------+--------------------------------------------- Comment (by 0booo5b02@sneakemail.com): At first sight it should work: svn shows that the portfile invokes config with the appropriate option: [source:/trunk/dports/multimedia/vobcopy/Portfile@36194#L21 Portfile] So this is probably a problem in {{{config.sh}}} I'll try to reproduce the problem. -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled ------------------------------+--------------------------------------------- Reporter: tom.duck@dal.ca | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: vobcopy lfs ------------------------------+--------------------------------------------- Comment (by tom.duck@dal.ca): To access lfs in vobcopy, HAS_LARGEFILE must be set to 1 in vobcopy.h. If you look at the Darwin section, you will notice that it is commented out. I will email the author to see if there is a reason why. -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled ------------------------------+--------------------------------------------- Reporter: tom.duck@dal.ca | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: vobcopy lfs ------------------------------+--------------------------------------------- Comment (by tom.duck@dal.ca): It appears that HAS_LARGEFILE was commented out between versions 1.0.2 and 1.1.0. There is no indication of why in the ChangeLog, and both the CVS and mailing list for vobcopy appear to be down. -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:4> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled ------------------------------+--------------------------------------------- Reporter: tom.duck@dal.ca | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: vobcopy lfs ------------------------------+--------------------------------------------- Comment (by 0booo5b02@sneakemail.com): I've been having a look and these are my conclusions: * {{{HAS_LARGEFILE}}} is not defined no matter what options are given to configure (on OS X) * There is no need for all the {{{O_LARGEFILE}}} juggling in the source. A regular open is sufficient (I tried this experimentally and it worked) * The code dealing with these issues is a mess Given all the previous points this is a bug from the upstream program. What I propose is this: I will make a patch that FAPP sets {{{HAS_LARGEFILE}}} but all open calls will be made without {{{O_LARGEFILE}}}). This will result in the {{{-l}}} being available but only really working on systems in which large file support doesn't depend on special options on open. On systems where that does happen a run time error will probably occur. I don't know in what systems this port will be compiled so the previous solution might break on some. Unless someone objects I'll write this patch to the source-code and attach it here. This project could really use something like autotools. -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled ------------------------------+--------------------------------------------- Reporter: tom.duck@dal.ca | Owner: macports-tickets@lists.macosforge.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: vobcopy lfs ------------------------------+--------------------------------------------- Comment (by tom.duck@dal.ca): I have been trying to contact the upstream author since June 21 without a response. The author has been blogging, so given that both the CVS and mailing list archive are down I am uncertain about the status of the project. If there is uncertainty about the behaviour on different systems, perhaps the patch should be set using an 'lfs' variant. That being said, isn't lfs supported on all systems supported by MacPorts (i.e., OS X 10.4 and 10.5)? I am blissfully unaware of issues surrounding lfs, and so can't comment on what side effects might result from using lfs on an unsupported system. -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled -----------------------------+---------------------------------------------- Reporter: tom.duck@… | Owner: 0booo5b02@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.6.0 Keywords: vobcopy lfs | Port: vobcopy -----------------------------+---------------------------------------------- Changes (by jmr@…): * cc: 0booo5b02@… (removed) * owner: macports-tickets@… => 0booo5b02@… * port: => vobcopy -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:8> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled -----------------------------+---------------------------------------------- Reporter: tom.duck@… | Owner: 0booo5b02@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.6.0 Keywords: vobcopy lfs | Port: vobcopy -----------------------------+---------------------------------------------- Comment(by adam@…): I have spoken to the developer, Robos via email recently. He says that vobcopy shouldn't have any problem with large file support on OS X. When the port is update to 1.2.0 (see ticket:20391) HAS_LARGEFILE should be enabled. -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled -----------------------------+---------------------------------------------- Reporter: tom.duck@… | Owner: 0booo5b02@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.6.0 Keywords: vobcopy lfs | Port: vobcopy -----------------------------+---------------------------------------------- Comment(by toby@…): might be fixed in r54189 -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:10> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled -----------------------------+---------------------------------------------- Reporter: tom.duck@… | Owner: 0booo5b02@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 1.6.0 Keywords: vobcopy lfs | Port: vobcopy -----------------------------+---------------------------------------------- Comment(by adam@…): r54189 does indeed fix this. -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:11> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15707: vobcopy lfs not enabled ------------------------------+--------------------------------------------- Reporter: tom.duck@… | Owner: 0booo5b02@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.6.0 Resolution: fixed | Keywords: vobcopy lfs Port: vobcopy | ------------------------------+--------------------------------------------- Changes (by jmr@…): * status: new => closed * resolution: => fixed -- Ticket URL: <http://trac.macports.org/ticket/15707#comment:12> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts