[MacPorts] #44351: Fix phonon cmake install
#44351: Fix phonon cmake install ---------------------------+-------------------------------- Reporter: springermac@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Keywords: | Port: phonon ---------------------------+-------------------------------- The PhononConfig.cmake file didn't set the rootDir properly and the PhononTargets-release.cmake file was using the import directory instead of the PHONON_LIBRARY_DIR. -- Ticket URL: <https://trac.macports.org/ticket/44351> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Changes (by mf2k@…): * cc: michaelld@… (removed) * owner: macports-tickets@… => michaelld@… * keywords: => haspatch -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.1 Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by ryandesign@…): If this changes files that get installed by the port, then the port's revision must be increased. -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Changes (by mk@…): * cc: mk@… (added) * version: 2.3.1 => -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by mk@…): This patch is against phonon 4.7.1. Is it correct that it wouldn't be needed with 4.7.2 as submitted in #44305? -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by springermac@…): No this will still be needed with 4.7.2. -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by michaelld@…): How do I test that the resulting "fixed" files are incorrect without this patch, and corrected with it? -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by springermac@…): I fixed this in the process of trying to build the phonon gstreamer backend so trying to build it without this patch should fail and with this patch should succeed. The only thing is that I would like is to fix this in the cmake files before phonon is built so the generated files are correct instead of trying to patch them after they are made and run the risk of possibly not taking into account a user's setup. I would try and fix the original cmake files but I don't have enough experience with cmake to do that. -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:8> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by michaelld@…): Can you provide whatever info I need to know to recreate your building of the gstreamer backend, so that I can test/verify the changes? Once I know what to do, I will try to fix in the source. But, without knowing what to do it's a little difficult to fix. -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:9> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by springermac@…): See ticket 44350 for the proposed portfile for the phonon-backend- gstreamer port. -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:10> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by michaelld@…): Got it. Yes, I see the issue now. I'll look into seeing if I can fix it in the phonon source instead of a post-destroot. -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:11> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by springermac@…): Awesome thanks! -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:12> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Comment (by michaelld@…): Fixed in r122949. -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:13> MacPorts <http://www.macports.org/> Ports system for OS X
#44351: Fix phonon cmake install ----------------------------+------------------------- Reporter: springermac@… | Owner: michaelld@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: phonon | ----------------------------+------------------------- Changes (by michaelld@…): * status: new => closed * resolution: => fixed -- Ticket URL: <https://trac.macports.org/ticket/44351#comment:14> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts