#44102: new portfile of peco -------------------------+-------------------------------- Reporter: noname@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.0 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by ryandesign@…): Thanks. Some initial observations: * the github portgroup and its "`github.setup`" procedure should be used, which will eliminate many lines (name, version, master_sites, distname, worksrcdir, livecheck.*) from the portfile * more than one checksum type should be used; typically, we want to use rmd160 and sha256 checksum types * there's no need to "`file mkdir ${destroot}/${prefix}/bin`"; MacPorts makes this and other standard directories for you * there should be no slash before "`${prefix}`" because "`${prefix}`" already begins with a slash -- Ticket URL: <https://trac.macports.org/ticket/44102#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X

#44102: new portfile of peco -------------------------+-------------------------------- Reporter: noname@… | Owner: macports-tickets@… Type: submission | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.0 Resolution: | Keywords: Port: | -------------------------+-------------------------------- Comment (by noname@…): thanks feedback. fixed some problems. https://github.com/withgod/portfile- peco/commit/f0b199ff34e7b2229c2826e865943f0a49fbc87d you say "eliminate many lines(name" but many Portfile contain name. kept name line. -- Ticket URL: <https://trac.macports.org/ticket/44102#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X

#44102: new portfile of peco -------------------------+-------------------------------- Reporter: noname@… | Owner: macports-tickets@… Type: submission | Status: closed Priority: Normal | Milestone: Component: ports | Version: 2.3.0 Resolution: invalid | Keywords: Port: | -------------------------+-------------------------------- Changes (by khindenburg@…): * status: new => closed * resolution: => invalid Comment: I'll go ahead and close this as peco is already in w/ a latter version. -- Ticket URL: <https://trac.macports.org/ticket/44102#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X