[MacPorts] #52608: updates for snappy & leveldb
#52608: updates for snappy & leveldb -------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Keywords: haspatch | Port: snappy, leveldb -------------------------+-------------------------------- Please find attached the latest updates for port:snappy and port:leveldb . I'm not particularly interested in becoming their maintainer, though. -- Ticket URL: <https://trac.macports.org/ticket/52608> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------------- Changes (by mf2k@…): * port: snappy, leveldb => snappy leveldb -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:1> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Changes (by ryandesign@…): * owner: macports-tickets@… => ryandesign@… * status: new => assigned Comment: Thanks. -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:2> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by ryandesign@…): Committed the snappy update in r153867 with these changes: * removed `name snappy` line and commented-out `#version 1.1.1` line * replaced tabs in changed lines with spaces * used release download, which avoids the need to run autoreconf -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:3> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by rjvbertin@…): Replying to [comment:3 ryandesign@…]:
* used release download, which avoids the need to run autoreconf
Hrmf, I thought I'd obtained that by specifying a release tag and now using fetch.type=git ... Running autoreconf isn't a big deal for a single build if you already have the tools installed, but it's true that it quickly grows old (and perceptually ever slower) if you have have to rerun the configure step repeatedly. -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:4> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Changes (by ryandesign@…): * status: assigned => closed * resolution: => fixed Comment: Committed the leveldb update in r153953 with these changes: * did not add `use_parallel_build yes` line because that's been the default for many years * removed comment-out `# build.args-append libmemenv.a` line; looks like libmemenv.a gets built by default now * set CFLAGS correctly, so that not just C++ code but also C code gets built for the correct arch (otherwise the universal variant failed) * removed the existing lines relating to changing the MacPorts default `-Os` optimization flag to `-O2` because no justification was given for making that change in r140702 * did not apply your change that installs the libleveldb.dylib files using /usr/bin/install instead of /bin/cp, because doing so causes three separate copies of the library to be installed, rather than one copy and two symlinks which is what we want * added patch to fix library install_name. This will require all ports linking with libleveldb,dylib to be revbumped. -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:5> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by rjvbertin@…): dang, I didn't notice the weird, linuxy library names... I've done this a bit between other things, but I did wonder why the port doesn't simply use a hand-written destroot rather than generate an install makefile and let that be executed... -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:6> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by ryandesign@…): Replying to [comment:6 rjvbertin@…]:
I did wonder why the port doesn't simply use a hand-written destroot rather than generate an install makefile and let that be executed...
That's explained in the Portfile:
{{{ # muniversal build requires Makefile }}}
-- Ticket URL: <https://trac.macports.org/ticket/52608#comment:7> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by rjvbertin@…): Oh, right, yes. Because muniversal also rolls its own destroot? -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:8> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by ryandesign@…): Yes. -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:9> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by ryandesign@…): Replying to [comment:5 ryandesign@…]:
This will require all ports linking with libleveldb.dylib to be revbumped.
Fixed caffe in r153955. The only other one is qt5-qtwebkit, which is still building. -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:10> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by ryandesign@…): Fixed qt5-qtwebkit in r153957. -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:11> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by rjvbertin@…): I'm not getting the patch file from svn, did you forget to commit it? -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:12> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
#52608: updates for snappy & leveldb -----------------------------+-------------------------- Reporter: rjvbertin@… | Owner: ryandesign@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: snappy leveldb | -----------------------------+-------------------------- Comment (by ryandesign@…): Yes; see #52631. Fixed in r153991. -- Ticket URL: <https://trac.macports.org/ticket/52608#comment:13> MacPorts <https://www.macports.org/> Ports system for the Mac operating system
participants (1)
-
MacPorts