[MacPorts] #15754: freeciv doesn't compile on 10.4 (patch included)
#15754: freeciv doesn't compile on 10.4 (patch included) --------------------------------+------------------------------------------- Reporter: simon@macports.org | Owner: rhwood@macports.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Keywords: | --------------------------------+------------------------------------------- Hi, I just tried updating freeciv to version 2.1.5 and it failed with the following error: {{{ In file included from graphics.c:31: /opt/local/include/SDL/SDL_syswm.h:55:22: error: X11/Xlib.h: No such file or directory }}} It looks it's missing the include path to `/usr/X11R6/include`, the following patch works for me: {{{ --- a/dports/games/freeciv/Portfile +++ b/dports/games/freeciv/Portfile @@ -47,3 +47,5 @@ configure.args \ --with-libiconv-prefix=${prefix} \ --with-sdl-prefix=${prefix} \ --mandir=${prefix}/share/man + +configure.cflags-append "-I/usr/X11R6/include" }}} Thanks, Simon -- Ticket URL: <http://trac.macports.org/ticket/15754> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15754: freeciv doesn't compile on 10.4 (patch included) ---------------------------------+------------------------------------------ Reporter: simon@macports.org | Owner: rhwood@macports.org Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by jmr@macports.org): Shouldn't it rather be: {{{ --- a/dports/games/freeciv/Portfile +++ b/dports/games/freeciv/Portfile @@ -47,3 +47,5 @@ configure.args \ --with-libiconv-prefix=${prefix} \ --with-sdl-prefix=${prefix} \ --mandir=${prefix}/share/man + +configure.cppflags-append -I${x11prefix}/include }}} But why does freeciv (as opposed to freeciv-x11) need the X includes at all? -- Ticket URL: <http://trac.macports.org/ticket/15754#comment:1> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15754: freeciv doesn't compile on 10.4 (patch included) ---------------------------------+------------------------------------------ Reporter: simon@macports.org | Owner: rhwood@macports.org Type: defect | Status: assigned Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------+------------------------------------------ Changes (by rhwood@macports.org): * status: new => assigned Comment: freeciv does not require X11, but libsdl does. Can you please post the output of "otool -L /opt/local/bin/civclient" here? -- Ticket URL: <http://trac.macports.org/ticket/15754#comment:2> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15754: freeciv doesn't compile on 10.4 (patch included) ---------------------------------+------------------------------------------ Reporter: simon@macports.org | Owner: rhwood@macports.org Type: defect | Status: assigned Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Resolution: | Keywords: ---------------------------------+------------------------------------------ Comment (by simon@macports.org): Sure, here it is: {{{ /opt/local/bin/civclient: /opt/local/lib/libintl.8.dylib (compatibility version 9.0.0, current version 9.2.0) /opt/local/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0) /opt/local/lib/libSDL_image-1.2.0.dylib (compatibility version 2.0.0, current version 2.5.0) /opt/local/lib/libSDL-1.2.0.dylib (compatibility version 12.0.0, current version 12.2.0) /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa (compatibility version 1.0.0, current version 11.0.0) /opt/local/lib/libfreetype.6.dylib (compatibility version 10.0.0, current version 10.17.0) /opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.3) /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 18.0.0) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices (compatibility version 1.0.0, current version 22.0.0) /opt/local/lib/libSDL_mixer-1.2.0.dylib (compatibility version 3.0.0, current version 3.6.0) /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 88.3.10) }}} -- Ticket URL: <http://trac.macports.org/ticket/15754#comment:3> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15754: freeciv doesn't compile on 10.4 (patch included) --------------------------------+------------------------------------------- Reporter: simon@… | Owner: rhwood@… Type: defect | Status: assigned Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Keywords: | Port: freeciv --------------------------------+------------------------------------------- Changes (by ryandesign@…): * port: => freeciv Comment: Does this problem persist with freeciv 2.1.8? -- Ticket URL: <http://trac.macports.org/ticket/15754#comment:5> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15754: freeciv doesn't compile on 10.4 (patch included) --------------------------------+------------------------------------------- Reporter: simon@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Keywords: | Port: freeciv --------------------------------+------------------------------------------- Changes (by rhwood@…): * owner: rhwood@… => macports-tickets@… * status: assigned => new -- Ticket URL: <http://trac.macports.org/ticket/15754#comment:6> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15754: freeciv doesn't compile on 10.4 (patch included) --------------------------------+------------------------------------------- Reporter: simon@… | Owner: blb@… Type: defect | Status: new Priority: Normal | Milestone: Port Bugs Component: ports | Version: 1.6.0 Keywords: | Port: freeciv --------------------------------+------------------------------------------- Changes (by blb@…): * owner: macports-tickets@… => blb@… Comment: Weird, my libsdl isn't linked against X11 at all, and I didn't use +no_x11...does libsdl build against X11 on 10.4 maybe but not 10.5? My libSDL.dylib is linked against a bunch of frameworks but no X11; also, when I run civclient (the latest 2.1.9), I see {{{ 2: Using Video Output: Quartz 2009-03-29 20:54:20.821 civclient[73446:10b] Warning once: This application, or a library it uses, is using NSQuickDrawView, which has been deprecated. Apps should cease use of QuickDraw and move to Quartz. }}} -- Ticket URL: <http://trac.macports.org/ticket/15754#comment:7> MacPorts <http://www.macports.org/> Ports system for Mac OS
#15754: freeciv doesn't compile on 10.4 (patch included) ---------------------------------+------------------------------------------ Reporter: simon@… | Owner: blb@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: 1.6.0 Resolution: worksforme | Keywords: Port: freeciv | ---------------------------------+------------------------------------------ Changes (by toby@…): * status: new => closed * resolution: => worksforme Comment: Nothing from reporter in 14 months, and given that we no longer have a separate x11prefix, this is probably resolved. -- Ticket URL: <http://trac.macports.org/ticket/15754#comment:9> MacPorts <http://www.macports.org/> Ports system for Mac OS
participants (1)
-
MacPorts