[MacPorts] #46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent -------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: haspatch | Port: kde4 -------------------------+-------------------------------- The kde4 1.1 PortGroup file contains hardcoded declarations for the QCA2 include and library directories. Those are inappropriate for qt4-mac +concurrent, and in my testing they are also not required. -- Ticket URL: <https://trac.macports.org/ticket/46240> MacPorts <https://www.macports.org/> Ports system for OS X
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: kde4 | --------------------------+-------------------------------- Changes (by mk@…): * cc: mk@… (added) * version: 2.3.3 => -- Ticket URL: <https://trac.macports.org/ticket/46240#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent --------------------------+-------------------------------- Reporter: rjvbertin@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: kde4 | --------------------------+-------------------------------- Comment (by mk@…): Sure that committing this won't break anything? For me it's unclear how to test this without rebuilding whole kdelibs4 and perhaps port:konversation... -- Ticket URL: <https://trac.macports.org/ticket/46240#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent --------------------------+---------------------- Reporter: rjvbertin@… | Owner: mk@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: kde4 | --------------------------+---------------------- Changes (by mk@…): * owner: macports-tickets@… => mk@… -- Ticket URL: <https://trac.macports.org/ticket/46240#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent --------------------------+---------------------- Reporter: rjvbertin@… | Owner: mk@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: kde4 | --------------------------+---------------------- Comment (by rjvbertin@…): This change won't require anything to be rebuilt. It removes instructions where to find QCA during a build. When I tried with the standard (traditional, exclusive) port:qt4-mac active those instructions were redundant (= not required), so removing them didn't break anything. For me. Testing is simple enough: `port -v configure foo` where foo is any KDE4 port that depends on port:qca (or possibly port:qca-ossl). If that doesn't raise errors or warnings about something qca-related not being found you have your proof. You can also double-check in the generated CMakeCache.txt file if the qca stuff is found in the correct locations. The reason that I like to have this committed is that PortGroup definitions outside the default repository apparently apply only to the ports in the same repository. Or maybe the rule is that a PortGroup definition in a port repository overrides PortGroup definitions from outside that repository. -- Ticket URL: <https://trac.macports.org/ticket/46240#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent --------------------------+---------------------- Reporter: rjvbertin@… | Owner: mk@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: kde4 | --------------------------+---------------------- Comment (by mk@…): Since I wasn't sure what you really meant in your last paragraph (w.r.t. default and same), I removed these two lines in my base installation, as well as in the checked out port group definition in the corresponding dports directory and ended up with this: {{{ ----------------------------------------------------------------------------- -- The following external packages were located on your system. -- This installation will have the extra features provided by these packages. ----------------------------------------------------------------------------- * QCA - Qt Cryptographic Architecture ----------------------------------------------------------------------------- -- Congratulations! All external packages have been found. ----------------------------------------------------------------------------- }}} meaning that a removal of these two options is possible. :-) -- Ticket URL: <https://trac.macports.org/ticket/46240#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent --------------------------+---------------------- Reporter: rjvbertin@… | Owner: mk@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: kde4 | --------------------------+---------------------- Comment (by mk@…): BTW, your patch wasn't applicable as is, since the portgroup had changed in the meantime. -- Ticket URL: <https://trac.macports.org/ticket/46240#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent --------------------------+---------------------- Reporter: rjvbertin@… | Owner: mk@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: kde4 | --------------------------+---------------------- Changes (by mk@…): * status: new => closed * resolution: => fixed Comment: Done in r133738 -- Ticket URL: <https://trac.macports.org/ticket/46240#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
#46240: kde4 1.1 PortGroup file adaptation to qt4-mac +concurrent --------------------------+---------------------- Reporter: rjvbertin@… | Owner: mk@… Type: enhancement | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: kde4 | --------------------------+---------------------- Comment (by mk@…): Thanks, René, for supplying just committed r133799. -- Ticket URL: <https://trac.macports.org/ticket/46240#comment:8> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts