[MacPorts] #46968: opusfile @0.6 does not build on 10.5.8
#46968: opusfile @0.6 does not build on 10.5.8 --------------------+-------------------------------- Reporter: hans@… | Owner: macports-tickets@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: | Port: opusfile --------------------+-------------------------------- On MacOSX 10.5.8, audio/opusfile does not build, because this version of MacOSX does not have AI_NUMERICSERV defined, and src/http.c fails to compile. {{{ :info:build src/http.c: In function 'op_resolve': :info:build src/http.c:725: error: 'AI_NUMERICSERV' undeclared (first use in this function) }}} It appears exactly once: {{{ #if !defined(_WIN32) hints.ai_flags=AI_NUMERICSERV; #endif }}} What's the right thing to do here? Can we just drop these three lines on older darwins? (Does someone know when exactly AI_NUMERICSERV became #defined in MacOSX's netdb.h?) Another solution is to just --disable-http for the appropriate darwin versions, which seems like overkill. -- Ticket URL: <https://trac.macports.org/ticket/46968> MacPorts <https://www.macports.org/> Ports system for OS X
#46968: opusfile @0.6 does not build on 10.5.8 -----------------------+---------------------- Reporter: hans@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: opusfile | -----------------------+---------------------- Changes (by mf2k@…): * owner: macports-tickets@… => devans@… Comment: In the future, please Cc the port maintainers ({{{port info --maintainers opusfile}}}), if any. -- Ticket URL: <https://trac.macports.org/ticket/46968#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#46968: opusfile @0.6 does not build on 10.5.8 -----------------------+---------------------- Reporter: hans@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: opusfile | -----------------------+---------------------- Comment (by hans@…): The attached diff to the Portfile and to src/http.c make opusfile compile on my 10.5.8 The "darwin 8" and "darwin 9" is a blind shot, I don't know when exactly AI_NUMERICSERV was introduced into MacOSX; someone please correct me. -- Ticket URL: <https://trac.macports.org/ticket/46968#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#46968: opusfile @0.6 does not build on 10.5.8 -----------------------+---------------------- Reporter: hans@… | Owner: devans@… Type: defect | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: Port: opusfile | -----------------------+---------------------- Comment (by mopihopi@…): `AI_NUMERICSERV` is defined on OS X 10.6.8. However it might be better to just change the `#if` to `#if defined(AI_NUMERICSERV)`, as that should work everywhere. -- Ticket URL: <https://trac.macports.org/ticket/46968#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#46968: opusfile @0.6 does not build on 10.5.8 -----------------------+---------------------- Reporter: hans@… | Owner: devans@… Type: defect | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: opusfile | -----------------------+---------------------- Changes (by devans@…): * status: new => assigned * version: 2.3.3 => Comment: Attached is my proposed patch to implement the fix as suggested in comment:3. If you can confirm that this fixes your issue, I'll go ahead and commit the fix. I've incremented the revision so that it will rebuild on all buildbots to ensure it works on 10.6+ but works for me on Mavericks and Yosemite. -- Ticket URL: <https://trac.macports.org/ticket/46968#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
#46968: opusfile @0.6 does not build on 10.5.8 -----------------------+---------------------- Reporter: hans@… | Owner: devans@… Type: defect | Status: assigned Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: opusfile | -----------------------+---------------------- Comment (by hans@…): Replying to [comment:5 devans@…]:
Attached is my proposed patch to implement the fix as suggested in comment:3. If you can confirm that this fixes your issue, I'll go ahead and commit the fix. I've incremented the revision so that it will rebuild on all buildbots to ensure it works on 10.6+ but works for me on Mavericks and Yosemite.
Yes, this fixes my issue (and I agree it is a much better fix) Thanks! -- Ticket URL: <https://trac.macports.org/ticket/46968#comment:6> MacPorts <https://www.macports.org/> Ports system for OS X
#46968: opusfile @0.6 does not build on 10.5.8 -----------------------+---------------------- Reporter: hans@… | Owner: devans@… Type: defect | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: Port: opusfile | -----------------------+---------------------- Changes (by devans@…): * status: assigned => closed * resolution: => fixed Comment: Committed in r133349, thanks to all for the report and the fix. I'm really dependent on you to help with these older systems since mine died some time ago. -- Ticket URL: <https://trac.macports.org/ticket/46968#comment:7> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts