[MacPorts] #48668: notmuch: Added +python variant
#48668: notmuch: Added +python variant -------------------------+-------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Keywords: haspatch | Port: notmuch -------------------------+-------------------------------- This patch add the correct support for a +python variant in the Portfile. The corresponding patch for globals.py was also updated appropriately. Cheers, Charles -- Ticket URL: <https://trac.macports.org/ticket/48668> MacPorts <https://www.macports.org/> Ports system for OS X
#48668: notmuch: Added +python variant --------------------------+-------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: notmuch | --------------------------+-------------------------------- Comment (by ryandesign@…): You should not use `system "cd ${worksrcpath}/bindings/python && ..."`. Instead, please use `system -W ${worksrcpath}/bindings/python "..."`. It looks like this uses python 2.7. As such the variant should probably be named python27 instead of just python. Since this doesn't add any additional dependencies (python27 is already a dependency through your patch in #48667), does this need to be a variant at all? Couldn't it just be always done? -- Ticket URL: <https://trac.macports.org/ticket/48668#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#48668: notmuch: Added +python variant --------------------------+-------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch Port: notmuch | --------------------------+-------------------------------- Comment (by cceleri@…): Ok. I was not aware of the -W option. Looks like it's right in front of me on the portfile(7) manpage though! Ideally the python27 dependency should be part of the python27 variant; I'm hesitant to role the variant into the normal installation since the bindings are not generally required to run notmuch on a daily basis. There are also bindings for ruby and go which I would like to support in the form of variants in the future too. I think an explicit python* dependency would be good for each python* variant since we will only need a particular python version to resolve the issue in #48667. -- Ticket URL: <https://trac.macports.org/ticket/48668#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#48668: notmuch: Added +python variant --------------------------+--------------------------------- Reporter: cceleri@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.3 Resolution: | Keywords: haspatch maintainer Port: notmuch | --------------------------+--------------------------------- Changes (by petr@…): * keywords: haspatch => haspatch maintainer -- Ticket URL: <https://trac.macports.org/ticket/48668#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts