[MacPorts] #38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan
#38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan -------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Keywords: | Port: -------------------------+-------------------------------- When running `autoscan` in base, it gives the following warnings: {{{ configure.ac: warning: missing AC_CHECK_FUNCS([dup2]) wanted by: src/machista1.0/tests/libmachista-test.c:76 configure.ac: warning: missing AC_CHECK_FUNCS([getcwd]) wanted by: src/darwintracelib1.0/darwintrace.c:403 configure.ac: warning: missing AC_CHECK_FUNCS([lchown]) wanted by: src/pextlib1.0/Pextlib.c:464 configure.ac: warning: missing AC_CHECK_FUNCS([localtime_r]) wanted by: src/programs/daemondo/main.c:128 configure.ac: warning: missing AC_CHECK_FUNCS([memmove]) wanted by: src/pextlib1.0/filemap.c:746 configure.ac: warning: missing AC_CHECK_FUNCS([mkdir]) wanted by: src/darwintracelib1.0/darwintrace.c:829 configure.ac: warning: missing AC_CHECK_FUNCS([munmap]) wanted by: src/machista1.0/libmachista.c:499 configure.ac: warning: missing AC_CHECK_FUNCS([realpath]) wanted by: src/pextlib1.0/realpath.c:67 configure.ac: warning: missing AC_CHECK_FUNCS([regcomp]) wanted by: src/pextlib1.0/strsed.c:584 configure.ac: warning: missing AC_CHECK_FUNCS([rmdir]) wanted by: src/darwintracelib1.0/darwintrace.c:859 configure.ac: warning: missing AC_CHECK_FUNCS([select]) wanted by: src/darwintracelib1.0/darwintrace.c:209 configure.ac: warning: missing AC_CHECK_FUNCS([setenv]) wanted by: src/pextlib1.0/Pextlib.c:408 configure.ac: warning: missing AC_CHECK_FUNCS([socket]) wanted by: src/darwintracelib1.0/darwintrace.c:359 configure.ac: warning: missing AC_CHECK_FUNCS([strchr]) wanted by: src/machista1.0/machista_wrap.c:1381 configure.ac: warning: missing AC_CHECK_FUNCS([strdup]) wanted by: src/cregistry/entry.c:384 configure.ac: warning: missing AC_CHECK_FUNCS([strerror]) wanted by: src/darwintracelib1.0/darwintrace.c:369 configure.ac: warning: missing AC_CHECK_FUNCS([strrchr]) wanted by: src/pextlib1.0/xinstall.c:466 configure.ac: warning: missing AC_CHECK_FUNCS([strstr]) wanted by: src/machista1.0/machista_wrap.c:1383 configure.ac: warning: missing AC_CHECK_FUNCS([strtol]) wanted by: src/pextlib1.0/Pextlib.c:205 configure.ac: warning: missing AC_CHECK_FUNCS([strtoul]) wanted by: src/machista1.0/machista_wrap.c:1820 configure.ac: warning: missing AC_CHECK_FUNCS([utime]) wanted by: src/pextlib1.0/curl.c:438 configure.ac: warning: missing AC_CHECK_HEADERS([mach/mach.h]) wanted by: src/programs/daemondo/main.c:66 configure.ac: warning: missing AC_CHECK_HEADERS([sys/ioctl.h]) wanted by: src/pextlib1.0/tty.c:41 configure.ac: warning: missing AC_CHECK_HEADERS([sys/mount.h]) wanted by: src/pextlib1.0/xinstall.c:50 configure.ac: warning: missing AC_CHECK_HEADERS([sys/param.h]) wanted by: src/darwintracelib1.0/darwintrace.c:70 configure.ac: warning: missing AC_CHECK_HEADERS([sys/time.h]) wanted by: src/pextlib1.0/sha2.c:38 configure.ac: warning: missing AC_CHECK_HEADER_STDBOOL wanted by: src/machista1.0/libmachista.c:247 configure.ac: warning: missing AC_C_INLINE wanted by: src/darwintracelib1.0/darwintrace.c:136 configure.ac: warning: missing AC_FUNC_CHOWN wanted by: src/pextlib1.0/xinstall.c:1077 configure.ac: warning: missing AC_FUNC_FORK wanted by: src/machista1.0/tests/libmachista-test.c:25 configure.ac: warning: missing AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK wanted by: src/darwintracelib1.0/darwintrace.c:721 configure.ac: warning: missing AC_FUNC_MALLOC wanted by: src/cregistry/entry.c:88 configure.ac: warning: missing AC_FUNC_MMAP wanted by: src/machista1.0/libmachista.c:469 configure.ac: warning: missing AC_FUNC_REALLOC wanted by: src/cregistry/util.c:56 configure.ac: warning: missing AC_PROG_AWK wanted by: portmgr/packaging/buildall.sh:44 configure.ac: warning: missing AC_PROG_RANLIB wanted by: src/cregistry/Makefile:5 configure.ac: warning: missing AC_TYPE_MODE_T wanted by: src/darwintracelib1.0/darwintrace.c:646 configure.ac: warning: missing AC_TYPE_OFF_T wanted by: src/pextlib1.0/flock.c:57 configure.ac: warning: missing AC_TYPE_PID_T wanted by: src/machista1.0/tests/libmachista-test.c:25 configure.ac: warning: missing AC_TYPE_SIZE_T wanted by: src/cregistry/entry.c:376 configure.ac: warning: missing AC_TYPE_SSIZE_T wanted by: src/darwintracelib1.0/darwintrace.c:687 configure.ac: warning: missing AC_TYPE_UID_T wanted by: src/pextlib1.0/Pextlib.c:464 configure.ac: warning: missing AC_TYPE_UINT32_T wanted by: src/machista1.0/hashmap.c:52 configure.ac: warning: missing AC_TYPE_UINT8_T wanted by: src/machista1.0/libmachista.c:87 }}} I'm running the most recent `autoscan` that MacPorts offers, which is: {{{ gl00b05044:base root# autoscan --version autoscan (GNU Autoconf) 2.69 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+/Autoconf: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>, <http://gnu.org/licenses/exceptions.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David J. MacKenzie and Akim Demaille. }}} Feel free to add as many of the missing macros as you think makes sense. -- Ticket URL: <https://trac.macports.org/ticket/38582> MacPorts <http://www.macports.org/> Ports system for OS X
#38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: Port: | --------------------------+-------------------------------- Comment (by egall@…): Attaching a patch next that fixes all of these warnings, plus also makes sure everything is quoted properly, and alphabetizes the header and function checks. (After that the "haspatch" keyword can be added) -- Ticket URL: <https://trac.macports.org/ticket/38582#comment:1> MacPorts <http://www.macports.org/> Ports system for OS X
#38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: haspatch Port: | --------------------------+-------------------------------- Changes (by larryv@…): * keywords: => haspatch -- Ticket URL: <https://trac.macports.org/ticket/38582#comment:2> MacPorts <http://www.macports.org/> Ports system for OS X
#38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: haspatch Port: | --------------------------+-------------------------------- Comment (by egall@…): Also this depends on #38579 -- Ticket URL: <https://trac.macports.org/ticket/38582#comment:3> MacPorts <http://www.macports.org/> Ports system for OS X
#38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: haspatch Port: | --------------------------+-------------------------------- Comment (by egall@…): hm looks like I'll have to update this to include the changes from r104693 now... actually I should probably have done this patch against the configure.ac in trunk in the first place anyway... -- Ticket URL: <https://trac.macports.org/ticket/38582#comment:4> MacPorts <http://www.macports.org/> Ports system for OS X
#38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: haspatch Port: | --------------------------+-------------------------------- Comment (by jmr@…): There is absolutely no point adding autoconf checks for this stuff unless we have fallback code for when it's not available. And really, I doubt we care about being ''that'' portable. -- Ticket URL: <https://trac.macports.org/ticket/38582#comment:5> MacPorts <http://www.macports.org/> Ports system for OS X
#38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: haspatch Port: | --------------------------+-------------------------------- Comment (by egall@…): I don't think any of these macros can actually fail, so I don't see why they'd need fallback code. They're just for adding more information about the user's system to their `config.log` and to their `config.h` (which I guess MacPorts doesn't use, but it could do so easily...). Also it looks like a lot of the macros currently in `configure.ac` were originally added with an older version of `autoscan`, this would be just updating those to a more recent version. Anyway I'm planning on editing a table into this post showing more about these macros: ||= Macro =||= contents of line `autoscan` is referring to when it says a file wants this macro =||= context (how the line is used) =||= human explanation for how adding the macro will be useful =|| ||= `AC_CHECK_FUNCS([dup2])` =||= =||= =||= =|| (coming back to this later...) -- Ticket URL: <https://trac.macports.org/ticket/38582#comment:6> MacPorts <http://www.macports.org/> Ports system for OS X
#38582: RFE: update the configure.ac file in base to silence some warnings produced by autoscan --------------------------+-------------------------------- Reporter: egall@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: base | Version: 2.1.3 Resolution: | Keywords: haspatch Port: | --------------------------+-------------------------------- Comment (by egall@…): OK I should be done justifying all of these macros by now... there are new patches against the latest base release here now, too. -- Ticket URL: <https://trac.macports.org/ticket/38582#comment:7> MacPorts <http://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts