[MacPorts] #51208: icu @55.1 — add a +norename variant
#51208: icu @55.1 — add a +norename variant ---------------------------------------+-------------------------------- Reporter: ken.mcglothlen@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: icu configuration variant | Port: icu ---------------------------------------+-------------------------------- From the icu [http://source.icu- project.org/repos/icu/icu/trunk/readme.html#RecBuild readme.html] file: "Disable renaming: By default, ICU library entry point names have an ICU version suffix. Turn this off for a system-level installation, to enable upgrading ICU without breaking applications." This turned out to be important for one of our applications that wasn't handling this gracefully, and because MacPorts is often used in a way that could be described as "system-level," it seemed like adding a new default variant was the right answer. The diff file is very simple, and it seems to work fine. I've added it as an attachment as well. {{{ --- Portfile.orig 2015-04-19 17:30:33.000000000 -0700 +++ Portfile 2016-04-22 05:11:34.000000000 -0700 @@ -31,6 +31,13 @@ worksrcdir ${name}/source set docdir ${prefix}/share/doc/${name} +default_variants +norename + +variant norename description {Disable library entry-point renaming} { + configure.args-append \ + --disable-renaming +} + subport ${name}-docs { conflicts ${name}-doxygen-docs supported_archs noarch }}} This is my first submission, so please let me know if I've done anything wrong. Thanks. -- Ticket URL: <https://trac.macports.org/ticket/51208> MacPorts <https://www.macports.org/> Ports system for OS X
#51208: icu @55.1 — add a +norename variant -------------------------------+--------------------------------------- Reporter: ken.mcglothlen@… | Owner: macports-tickets@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Resolution: | Keywords: icu configuration variant Port: icu | -------------------------------+--------------------------------------- Comment (by ken.mcglothlen@…): I realize this was ambiguous, so I'll clarify: It does seem to have fixed our problem with the other application as well, which is no longer looking for an incorrect entry point. -- Ticket URL: <https://trac.macports.org/ticket/51208#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51208: icu @55.1 — add a +norename variant -------------------------------+-------------------------- Reporter: ken.mcglothlen@… | Owner: ryandesign@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icu | -------------------------------+-------------------------- Changes (by mf2k@…): * keywords: icu configuration variant => * owner: macports-tickets@… => ryandesign@… * version: 2.3.4 => Comment: In the future, please Cc the port maintainers ({{{port info --maintainers icu}}}), if any. -- Ticket URL: <https://trac.macports.org/ticket/51208#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51208: icu @55.1 — add a +norename variant -------------------------------+-------------------------- Reporter: ken.mcglothlen@… | Owner: ryandesign@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: Port: icu | -------------------------------+-------------------------- Comment (by ken.mcglothlen@…): Replying to [comment:2 mf2k@…]: Thank you. I'll keep that in mind for next time. -- Ticket URL: <https://trac.macports.org/ticket/51208#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51208: icu @55.1 — add a +norename variant -------------------------------+-------------------------- Reporter: ken.mcglothlen@… | Owner: ryandesign@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: icu | -------------------------------+-------------------------- Changes (by ryandesign@…): * keywords: => haspatch Comment: We don't use negatively-named variants anymore (e.g. variant name begins with "no"). Disabling entry point renaming by default would change the files installed by the port, which would warrant the port's revision being increased. Wouldn't disabling entry point renaming cause all ports linked with the library to no longer work (because they were using the renamed entry points) and need to be rebuilt? Wouldn't making this a choice that a user can select via variant mean that a port built against icu with the variant selected would not work with icu without the variant selected, and vice versa? This would wreak havoc given that we build binaries on our servers, using only default variants. -- Ticket URL: <https://trac.macports.org/ticket/51208#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
#51208: icu @55.1 — add a +norename variant -------------------------------+-------------------------- Reporter: ken.mcglothlen@… | Owner: ryandesign@… Type: enhancement | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: icu | -------------------------------+-------------------------- Comment (by ken.mcglothlen@…): As to the first two points, I assumed those weren't really my call in the first place, and I expected that the patch wouldn't be accepted as is. Suggestions for a variant name are welcome; I was guided in my choice by ‘boost’, which has both a +no_static and a +no_single variant by default (though I admit, I omitted the underscore). I'm perfectly willing to resubmit my patch with whatever more experienced port maintainers prefer. As to “wreak havoc,” I would think that having entry points that ''didn't'' change names with every new version would actually be a plus for dynamic linking. Sure, there would be a need to force a rebuild on dependent ports, but only the first time. As the portfile says: {{{ # Don't forget to increase the revision number of the dependents (e.g. boost) # whenever the library version number changes. Thanks. }}} If the entry points didn't change names with version numbers, wouldn't that requirement go away? Or do programmers that use libraries such as icu prefer to link with version-specific entry points (in which case, why would one use dynamic linking in the first place)? (I'm not trying to be sarcastic; it's a genuine question.) -- Ticket URL: <https://trac.macports.org/ticket/51208#comment:5> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts