[MacPorts] #51348: bash-completion @2.1: update to 2.3
#51348: bash-completion @2.1: update to 2.3 ---------------------------+-------------------------------- Reporter: xeron.oskom@… | Owner: macports-tickets@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: 2.3.4 Keywords: haspatch | Port: bash-completion ---------------------------+-------------------------------- bash-completion project has been moved to https://github.com/scop/bash- completion There's a new version 2.3. Patch attached. -- Ticket URL: <https://trac.macports.org/ticket/51348> MacPorts <https://www.macports.org/> Ports system for OS X
#51348: bash-completion @2.1: update to 2.3 ------------------------------+---------------------- Reporter: xeron.oskom@… | Owner: raimue@… Type: update | Status: new Priority: Normal | Milestone: Component: ports | Version: Resolution: | Keywords: haspatch Port: bash-completion | ------------------------------+---------------------- Changes (by mf2k@…): * cc: raimue@… (removed) * owner: macports-tickets@… => raimue@… * version: 2.3.4 => -- Ticket URL: <https://trac.macports.org/ticket/51348#comment:1> MacPorts <https://www.macports.org/> Ports system for OS X
#51348: bash-completion @2.1: update to 2.3 ------------------------------+---------------------- Reporter: xeron.oskom@… | Owner: raimue@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: bash-completion | ------------------------------+---------------------- Changes (by raimue@…): * status: new => closed * resolution: => fixed Comment: Thank you for the patch, very good work with all the patch files! I was not aware of the move and also the livecheck did not pick it up as the original website is still online (and only redirects with JavaScript). Some comments and changes I applied: * No need to increase the epoch, the version numbering scheme did not change * Release tarballs are preferred over tarballs generated by GitHub * Retain bash-completion-devel for the time being until it is properly marked as replaced_by and then removed Committed with these changes in r148553. -- Ticket URL: <https://trac.macports.org/ticket/51348#comment:2> MacPorts <https://www.macports.org/> Ports system for OS X
#51348: bash-completion @2.1: update to 2.3 ------------------------------+---------------------- Reporter: xeron.oskom@… | Owner: raimue@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: bash-completion | ------------------------------+---------------------- Comment (by xeron.oskom@…): Thanks you! I'm ok with all you changes, but adding some comments just FYI:
* No need to increase the epoch, the version numbering scheme did not change
For some reason `port -u upgrade outdated` didn't update it for me until I bumped `epoch`.
* Release tarballs are preferred over tarballs generated by GitHub
If release tarballs are preferred why don't we set `github.tarball_from releases` by default? I actually didn't know about `github.tarball_from` parameter and it wasn't working w/o `v` after version so I just put it there :)
* Retain bash-completion-devel for the time being until it is properly marked as replaced_by and then removed
We should probably do this since `bash-completion-devel` is somehow useless right now. -- Ticket URL: <https://trac.macports.org/ticket/51348#comment:3> MacPorts <https://www.macports.org/> Ports system for OS X
#51348: bash-completion @2.1: update to 2.3 ------------------------------+---------------------- Reporter: xeron.oskom@… | Owner: raimue@… Type: update | Status: closed Priority: Normal | Milestone: Component: ports | Version: Resolution: fixed | Keywords: haspatch Port: bash-completion | ------------------------------+---------------------- Comment (by raimue@…): Replying to [comment:3 xeron.oskom@…]:
* Release tarballs are preferred over tarballs generated by GitHub
If release tarballs are preferred why don't we set `github.tarball_from releases` by default? I actually didn't know about `github.tarball_from` parameter and it wasn't working w/o `v` after version so I just put it there :)
Release tarballs are attached manually to a release (usually what `make dist` produces for automake-based build systems). Not all projects release such tarballs, so the default is what works for every project. The default for the github port group fetches a tarball that is generated by GitHub from version control, which does not include the configure scripts, automake helpers, m4 macros, etc.
* Retain bash-completion-devel for the time being until it is properly marked as replaced_by and then removed
We should probably do this since `bash-completion-devel` is somehow useless right now.
Agreed, I will look into that. -- Ticket URL: <https://trac.macports.org/ticket/51348#comment:4> MacPorts <https://www.macports.org/> Ports system for OS X
participants (1)
-
MacPorts